Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding titles to vrfy plots #578

Merged
merged 4 commits into from
Aug 24, 2023
Merged

adding titles to vrfy plots #578

merged 4 commits into from
Aug 24, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

This is a first pass and can be modified in the future. Basic format is experiment, PDY, cyc, variable, and then additional info such as level or latitude. This will probably have conflicts with Mindo's work, but probably nothing serious.

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Aug 22, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Aug 22, 2023
@emcbot
Copy link

emcbot commented Aug 22, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Aug 22 21:04:08 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Aug 22 22:10:26 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Aug 22 22:55:00 UTC 2023
Tests: 85% tests passed, 8 tests failed out of 55
	1593 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
	1595 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
	1596 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
	1597 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1599 - test_gdasapp_soca_incr_handler (Failed)
	1613 - test_gdasapp_atm_jjob_var_init (Failed)
	1614 - test_gdasapp_atm_jjob_var_run (Failed)
	1615 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/578/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Aug 22, 2023
@emcbot
Copy link

emcbot commented Aug 22, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Aug 22 16:03:34 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Aug 22 17:41:06 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Aug 22 18:18:07 CDT 2023
Tests: 85% tests passed, 8 tests failed out of 55
	1593 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
	1595 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
	1596 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
	1597 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1599 - test_gdasapp_soca_incr_handler (Failed)
	1613 - test_gdasapp_atm_jjob_var_init (Failed)
	1614 - test_gdasapp_atm_jjob_var_run (Failed)
	1615 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/578/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Aug 22, 2023
@CoryMartin-NOAA
Copy link
Contributor

lol why do all these tests fail?

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, we need to figure out why the tests are failing (most likely irrelevant to this PR)

@guillaumevernieres
Copy link
Contributor

guillaumevernieres commented Aug 23, 2023 •
edited
Loading

Looks fine, we need to figure out why the tests are failing (most likely irrelevant to this PR)

We need to update a yaml file the cmakelist, I'll submit a bugfix today.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Aug 23, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Aug 23, 2023
@emcbot
Copy link

emcbot commented Aug 23, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Aug 23 23:01:06 UTC 2023 on hfe07
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Wed Aug 23 23:35:43 UTC 2023
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/578/global-workflow/sorc/log.build

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Aug 23, 2023
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Aug 24, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Aug 24, 2023
@CoryMartin-NOAA CoryMartin-NOAA added the orion-GW-RT Queue for automated testing with global-workflow on Orion label Aug 24, 2023
@emcbot
Copy link

emcbot commented Aug 24, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Aug 24 13:05:34 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug 24 14:13:08 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Aug 24 15:09:59 UTC 2023
Tests: 91% tests passed, 5 tests failed out of 55
	1627 - test_gdasapp_atm_jjob_var_init (Failed)
	1628 - test_gdasapp_atm_jjob_var_run (Failed)
	1629 - test_gdasapp_atm_jjob_var_final (Failed)
	1632 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/578/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Aug 24, 2023
@emcbot
Copy link

emcbot commented Aug 24, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Aug 24 10:18:00 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Aug 24 11:36:34 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Aug 24 11:59:02 CDT 2023
Tests: 95% tests passed, 3 tests failed out of 55
	1627 - test_gdasapp_atm_jjob_var_init (Failed)
	1628 - test_gdasapp_atm_jjob_var_run (Failed)
	1629 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/578/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Aug 24, 2023
@guillaumevernieres guillaumevernieres merged commit 57e2a50 into develop Aug 24, 2023
23 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/vrfy-titles branch September 11, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewEichmann-NOAA @emcbot @CoryMartin-NOAA @guillaumevernieres