AEFEUP history and presidents #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePeras
force-pushed
the
page/aefeup_history
branch
from
1e63bd7
to
bc5862f
Compare
❌ Deploy Preview for websiteae failed.
|
rcachaldora
requested changes
Sep 30, 2024
| collection: 'president', | ||
| }); | ||
|
|
||
| return <AEFEUPHistoryClientPage history_text={history_text} presidents={presidents.docs} />; |
There was a problem hiding this comment.
I'd add the president info as a card. It woyld be nice if it were similar to the about us page, but we might not have the portarit of all presidents.
There was a problem hiding this comment.
Ye, that is the issue. We might want a card looking cool without photo. Later I will include the Horizontally Avatar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16