Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

299 custom reason for application rejection #341

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

odracir04
Copy link

the reason in the rejection email is now allowed to be specified by admins in the post request.

@odracir04 odracir04 linked an issue Nov 29, 2023 that may be closed by this pull request
Copy link

render bot commented Nov 29, 2023

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (82886d0) to head (bef70d2).

❗ Current head bef70d2 differs from pull request most recent head 47b92c2. Consider uploading reports for the commit 47b92c2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
- Coverage    90.34%   90.33%   -0.01%     
===========================================
  Files           54       54              
  Lines         1470     1469       -1     
  Branches       246      245       -1     
===========================================
- Hits          1328     1327       -1     
  Misses         137      137              
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odracir04
Copy link
Author

it's worth mentioning that we had to alter the tests to include the new rejection messages but the tests cover the new code

@Naapperas
Copy link
Member

@odracir04 please rebase and update the package-lock.json file so this PR can be reviewed.

@jose-carlos-sousa jose-carlos-sousa self-assigned this Apr 9, 2024
@jose-carlos-sousa jose-carlos-sousa force-pushed the 299-custom-reason-for-application-rejection branch from b384d98 to 8992eff Compare April 9, 2024 22:35
@jose-carlos-sousa jose-carlos-sousa force-pushed the 299-custom-reason-for-application-rejection branch from f038ecc to 47b92c2 Compare April 9, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom reason for application rejection
3 participants