Merge pull request #344 from NIAEFEUP/fix/image-upload-company-edit

Removed url and string constraint from file image argument
NIAEFEUP · Mar 13, 2024 · 82886d0 · 82886d0
2 parents 81bce7c + f8194c1
commit 82886d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/api/middleware/validators/company.js b/src/api/middleware/validators/company.js
@@ -131,6 +131,4 @@ export const edit = useExpressValidators([
         .withMessage(ValidationReasons.ARRAY_SIZE(CompanyConstants.contacts.min_length, CompanyConstants.contacts.max_length)),
     body("logo", ValidationReasons.DEFAULT)
         .optional()
-        .isString().withMessage(ValidationReasons.STRING).bail()
-        .isURL().withMessage(ValidationReasons.URL),
 ]);
diff --git a/src/api/routes/company.js b/src/api/routes/company.js
@@ -13,7 +13,7 @@ import { concurrentOffersNotExceeded } from "../middleware/validators/validatorU
 
 import { or } from "../middleware/utils.js";
 
-import * as fileMiddleware  from "../middleware/files.js";
+import * as fileMiddleware from "../middleware/files.js";
 import OfferService from "../../services/offer.js";
 import AccountService from "../../services/account.js";
 import Offer from "../../models/Offer.js";
@@ -245,7 +245,8 @@ export default (app) => {
             try {
                 const companyService = new CompanyService();
                 const offerService = new OfferService();
-                const company = await companyService.changeAttributes(req.params.companyId, req.body);
+                const logo = req.file && (req?.file?.url || `${config.webserver_host}/static/${req.file.filename}`);
+                const company = await companyService.changeAttributes(req.params.companyId, { ...req.body, logo });
                 await offerService.updateAllOffersByCompanyId(company);
                 return res.json(company);
             } catch (err) {