Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFS-dev PR#26 #98

Merged
merged 7 commits into from
Jun 29, 2023
Merged

UFS-dev PR#26 #98

merged 7 commits into from
Jun 29, 2023

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented May 9, 2023 •
edited
Loading

Identical to ufs-community#1509

The following RTs are expected to fail:
control_flake
hrrr_control
hrrr_control_decomp
hrrr_control_2threads
hrrr_control_restart
hrrr_control_debug
rap_clm_lake_debug
rap_flake_debug
hrrr_control_dyn32_phy32
hrrr_control_2threads_dyn32_phy32
hrrr_control_decomp_dyn32_phy32
hrrr_control_restart_dyn32_phy32
hrrr_control_debug_dyn32_phy32

DusanJovic-NOAA and others added 4 commits April 24, 2023 11:25
@DusanJovic-NOAA
Use nccmp to compare netcdf files in regression test on NOAA R&D mach…
46ef6d5 
…ines. Update WW3 (ufs-community#1702)

* Use nccmp to compare netcdf files

* Use nccmp only on NOAA R&D systems

* Do not skip checking fv_core.res.nc when GNU compiler is used

* Update ufs_common.lua

* Update ufs_hera modulefiles

* Cleanup compile.sh. Remove unnecessary FIXME for gnu compiler

* Update WW3
@SamuelTrahanNOAA
Add CLM Lake Model and update Flake (ufs-community#1509)
3cc95d6 
setup RT for flake

* add fv3-conf for flake

* add clm lake to FV3

* bug fixes, clm lake restart, and clm lake suite

* flake_control_run.IN => lake_control_run.IN
@grantfirl
Merge commit '3cc95d67' into ufs-dev-PR26
e23c8ff
@grantfirl
Merge branch 'main' into ufs-dev-PR26
f651b67
@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: RT
Please make changes and add the following label back: cheyenne-gnu-RT

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
Please make changes and add the following label back: cheyenne-intel-RT

@grantfirl
Copy link
Collaborator Author

grantfirl commented Jun 13, 2023 •
edited
Loading

new input data has been staged on Hera and Cheyenne

@grantfirl grantfirl marked this pull request as ready for review June 13, 2023 15:49
@grantfirl grantfirl requested a review from mkavulich June 13, 2023 15:49
@grantfirl
Copy link
Collaborator Author

Hera intel results:
control_flake 024 failed in check_result
control_flake 024 failed in run_test
hrrr_control 066 failed in run_test
hrrr_control_decomp 067 failed in run_test
hrrr_control_2threads 068 failed in run_test
hrrr_control_debug 098 failed in run_test
rap_clm_lake_debug 109 failed in check_result
rap_clm_lake_debug 109 failed in run_test
rap_flake_debug 110 failed in run_test
hrrr_control_dyn32_phy32 114 failed in run_test
hrrr_control_2threads_dyn32_phy32 116 failed in run_test
hrrr_control_decomp_dyn32_phy32 117 failed in run_test
hrrr_control_debug_dyn32_phy32 122 failed in run_tes

cheyenne intel results:
control_flake 021 failed in run_test
control_restart_p8 036 failed in run_test
control_decomp_p8 039 failed in run_test
control_p8_lndp 041 failed in run_test
control_p8_rrtmgp 042 failed in run_test
merra2_thompson 044 failed in run_test
regional_2threads 050 failed in run_test
regional_netcdf_parallel 052 failed in run_test
hrrr_control 063 failed in run_test
hrrr_control_decomp 064 failed in run_test
hrrr_control_2threads 065 failed in run_test
hrrr_control_debug 095 failed in run_test
rap_clm_lake_debug 106 failed in run_test
rap_flake_debug 107 failed in run_test
hrrr_control_dyn32_phy32 111 failed in run_test
hrrr_control_2threads_dyn32_phy32 113 failed in run_test
hrrr_control_decomp_dyn32_phy32 114 failed in run_test
hrrr_control_debug_dyn32_phy32 119 failed in run_test

@grantfirl
Copy link
Collaborator Author

@mkavulich This has finished testing. It is ready for merging once approved along with NCAR/fv3atm#95, NCAR/ccpp-physics#1016, and NCAR/ccpp-scm#387.

@grantfirl
Copy link
Collaborator Author

new baselines moved into main-20230615 on cheyenne and hera into default directories

mkavulich
mkavulich approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I have some questions about the specifics of what was changed here but that's more appropriate for discussion in the ufs-community repo.

@dustinswales
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
Please make changes and add the following label back: hera-intel-RT

@mkavulich
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/BMC/gmtb/RT/auto_RT/Pull_Requests/1344127077/20230628231623/ufs-weather-model
Please make changes and add the following label back: hera-intel-RT

@grantfirl grantfirl merged commit b326a8f into NCAR:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkavulich mkavulich mkavulich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grantfirl @dustinswales @mkavulich @DusanJovic-NOAA @SamuelTrahanNOAA