Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR70+PR71 #100

Merged
merged 20 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1ac938c
Create new baseline to fix the issue with develop-20230504 and recove…
jkbk2004 May 12, 2023
e403bb4
Add Unstructured WW3 mesh capability to UFS (#1727)
DeniseWorthen May 15, 2023
2cf2227
Update build for gfsv17 test to use -D32BIT=ON and set fewer tests fo…
JessicaMeixner-NOAA May 16, 2023
52cee26
Multiple domains quilting restart (#1722)
DusanJovic-NOAA May 19, 2023
7d015e1
update MOM6 to its main repository 20230504 updating (#1736)
jiandewang May 22, 2023
daa456c
Updating nemelist templates and configuration files to have consisten…
SadeghTabas-NOAA May 25, 2023
f809067
[develop] Update documentation with land configurations and general u…
gspetro-NOAA May 25, 2023
5d47ea8
Regression Testing Updates: GNU/Intel into one RT. New logs/ dir in t…
BrianCurtis-NOAA May 31, 2023
571a561
Hafs range check3d (#1743)
dkokron Jun 6, 2023
2f71156
Bugfixes for RRTMGP (#1751)
dustinswales Jun 8, 2023
bf60924
MYNN fix for numerical stability issues with mixing snow (#1754)
joeolson42 Jun 12, 2023
d2e2158
Merge commit 'bf60924' into ufs-dev-PR71
grantfirl Jun 26, 2023
f36eea8
Merge branch 'main' into ufs-dev-PR71
grantfirl Jun 29, 2023
2a066c2
update FV3 submodule pointer
grantfirl Jun 29, 2023
de3299b
Merge branch 'main' into ufs-dev-PR71
grantfirl Jul 19, 2023
cac7991
update NCAR-specific rt.sh script
grantfirl Jul 25, 2023
d81d530
udpate BL_DATE and add successful Hera log
grantfirl Jul 27, 2023
f640ee3
add successful Cheyenne log
grantfirl Jul 27, 2023
9218fd2
remove old logs
grantfirl Jul 28, 2023
96433c2
udpate FV3 submodule pointer and .gitmodules
grantfirl Aug 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,15 @@
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
-->

### Top of commit queue on: TBD
<!-- Please have sub-component Code Managers ready for merging sub-component PR's on the date above and the day after the date above -->

### Input data additions/changes
- [ ] No changes are expected to input data.
- [ ] There will be new input data. <!-- Add "input data change" Label -->
- [ ] Input data will be updated. <!-- Add "New Input Data Req'd" Label -->
- [ ] Changes are expected to input data:
- [ ] New input data.
- [ ] Updated input data.

### Anticipated changes to regression tests:
- [ ] No changes are expected to any regression test. <!-- Add "No Baseline Change" Label -->
- [ ] Changes are expected to the following tests: <!-- Add "Baseline Change" Label -->
- [ ] No changes are expected to any regression test.
- [ ] Changes are expected to the following tests:
<!-- Please insert what RT's change and why you expect them to change -->

## Subcomponents involved:
Expand All @@ -37,19 +35,21 @@ Provide a detailed description of what this PR does. What bug does it fix, or wh
<!--
Please complete all items in list. Make sure to attach logs from RT testing in comment, not in repository. Once all boxes are checked, please add the label "Ready for Commit Queue".
-->
- [ ] Link PR's from all sub-components involved
- [ ] Confirm reviews completed in sub-component PR's
- [ ] Link PR's from all sub-components involved in section below
- [ ] Confirm reviews completed in ALL sub-component PR's
- [ ] Add all appropriate labels to this PR.
- [ ] Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
- [ ] Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
- [ ] Add list of any failed regression tests to "Anticipated changes to regression tests" section.

## Linked PR's and Issues:
<!--
Please link dependent pull requests.
EXAMPLE: Depends on NOAA-EMC/fv3atm/pull/<pullrequest_number>
EXAMPLE: "- Depends on NOAA-EMC/fv3atm/pull/<pullrequest_number>"

Please link the related issues to be closed with this PR, whether in this repository, or in another repository.
EXAMPLE: Closes NOAA-EMC/fv3atm/issues/<issue_number>
EXAMPLE: "- Closes NOAA-EMC/fv3atm/issues/<issue_number>"

PLEASE MAKE SURE TO USE THE - with a space before the "Depends on" or "Closes" as they show up well on github.
-->

## Testing Day Checklist:
Expand All @@ -61,15 +61,11 @@ Please consult the ufs-weather-model [wiki](https://github.com/ufs-community/ufs

### Testing Log (for CM's):
- RDHPCS
- Intel
- [ ] Hera
- [ ] Orion
- [ ] Jet
- [ ] Gaea
- [ ] Cheyenne
- GNU
- [ ] Hera
- [ ] Cheyenne
- [ ] Hera
- [ ] Orion
- [ ] Jet
- [ ] Gaea
- [ ] Cheyenne
- WCOSS2
- [ ] Dogwood/Cactus
- [ ] Acorn
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,4 @@ tests/fv3_conf/compile_slurm.IN
tests/fv3_conf/compile_qsub.IN
tests/fv3_conf/fv3_slurm.IN
tests/fv3_conf/fv3_qsub.IN
log*
build*.log*
3 changes: 3 additions & 0 deletions CDEPS-interface/cdeps_files.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ list(APPEND cdeps_datm_files
CDEPS/datm/datm_datamode_era5_mod.F90
CDEPS/datm/datm_datamode_gefs_mod.F90
CDEPS/datm/datm_datamode_gfs_mod.F90
CDEPS/datm/datm_datamode_gfs_hafs_mod.F90
CDEPS/datm/datm_datamode_jra_mod.F90
)

Expand All @@ -62,6 +63,8 @@ list(APPEND cdeps_docn_files
CDEPS/docn/docn_datamode_copyall_mod.F90
CDEPS/docn/docn_datamode_iaf_mod.F90
CDEPS/docn/docn_datamode_som_mod.F90
CDEPS/docn/docn_datamode_cplhist_mod.F90
CDEPS/docn/docn_import_data_mod.F90
CDEPS/docn/ocn_comp_nuopc.F90
)

Expand Down
7 changes: 6 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ set(OPENMP ON CACHE BOOL "Enable OpenMP threading")
set(PARALLEL_NETCDF OFF CACHE BOOL "Enable parallel NetCDF")
set(JEDI_DRIVER OFF CACHE BOOL "Enable JEDI as top level driver")
set(CMEPS_AOFLUX OFF CACHE BOOL "Enable atmosphere-ocean flux calculation in mediator")
set(PDLIB OFF CACHE BOOL "Enable Domain Decomposition in WW3 via PDLIB")

set(CMAKE_Platform $ENV{CMAKE_Platform})
if(CMAKE_Platform)
Expand Down Expand Up @@ -206,7 +207,11 @@ if(WW3)
set(UFS_CAP "MULTI_ESMF" CACHE STRING "Build with MULTI_ESMF cap")
list(APPEND _ufs_defs_private FRONT_WW3=WMESMFMD)
else()
set(SWITCH "meshcap" CACHE STRING "NUOPC mesh cap")
if(PDLIB)
set(SWITCH "meshcap_pdlib" CACHE STRING "NUOPC mesh cap")
else()
set(SWITCH "meshcap" CACHE STRING "NUOPC mesh cap")
endif()
set(UFS_CAP "NUOPC_MESH" CACHE STRING "Build with NUOPC_MESH cap")
list(APPEND _ufs_defs_private FRONT_WW3=wav_comp_nuopc)
endif()
Expand Down
2 changes: 1 addition & 1 deletion FV3
2 changes: 1 addition & 1 deletion MOM6-interface/MOM6
Submodule MOM6 updated 206 files
5 changes: 3 additions & 2 deletions MOM6-interface/mom6_files.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ list(APPEND mom6_src_files
MOM6/src/ALE/coord_hycom.F90
MOM6/src/ALE/coord_rho.F90
MOM6/src/ALE/coord_sigma.F90
MOM6/src/ALE/coord_slight.F90
MOM6/src/ALE/coord_zlike.F90
MOM6/src/ALE/MOM_hybgen_regrid.F90
MOM6/src/ALE/MOM_hybgen_remap.F90
Expand All @@ -22,6 +21,7 @@ list(APPEND mom6_src_files
MOM6/src/ALE/regrid_edge_values.F90
MOM6/src/ALE/regrid_interp.F90
MOM6/src/ALE/regrid_solvers.F90
MOM6/src/ALE/remapping_attic.F90

MOM6/src/core/MOM.F90
MOM6/src/core/MOM_CoriolisAdv.F90
Expand Down Expand Up @@ -109,7 +109,6 @@ list(APPEND mom6_src_files
MOM6/src/framework/MOM_data_override.F90
MOM6/src/framework/MOM_diag_mediator.F90
MOM6/src/framework/MOM_diag_remap.F90
MOM6/src/framework/MOM_diag_vkernels.F90
MOM6/src/framework/MOM_document.F90
MOM6/src/framework/MOM_domains.F90
MOM6/src/framework/MOM_dyn_horgrid.F90
Expand All @@ -122,6 +121,8 @@ list(APPEND mom6_src_files
MOM6/src/framework/MOM_interpolate.F90
MOM6/src/framework/MOM_intrinsic_functions.F90
MOM6/src/framework/MOM_io.F90
MOM6/src/framework/MOM_io_file.F90
MOM6/src/framework/MOM_netcdf.F90
MOM6/src/framework/posix.F90
MOM6/src/framework/MOM_random.F90
MOM6/src/framework/MOM_restart.F90
Expand Down
1 change: 1 addition & 0 deletions doc/UsersGuide/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
sphinxcontrib-bibtex
sphinx_rtd_theme
docutils==0.16
Loading