Port to proj 6 #173
Open
Port to proj 6 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@zklaus Please update your fork with the upstream |
|
Just an FYI: NCL does not seem to be installing properly due to libnfp. Don't have an idea for now how it is related to changes in this PR though ('default` branch ubuntu tests pass) |
hCraker
force-pushed
the
develop
branch
2 times, most recently
from
12ae29f
to
8a96101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports NCL to the Proj 6 API. This new API was introduced in Proj 6 (2018). At the same time, the old API, which is used in NCL, was deprecated. With the release of Proj 8 (2021), the deprecated API was removed. Consequently, the highest supported version of Proj for NCL is Proj 7.2.0. This PR removes this upper limit and introduces effectively a lower limit, i.e. the oldest version of Proj that is supported is Proj 6.0.0.