Fix runtime_mult and Update remaining data retrieval scripts #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
@grantfirl Good catch! And thanks for reworking the runtime_multi option for DEPHY!
|
@mkavulich One more change based on your feedback -- automatically grab the suites necessary for running RTs as the "default" build option rather than supported suites only. |
mkavulich
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
@grantfirl thanks for getting this turned around so quickly. Runtimes seem to be behaving correctly, and the default suites are now identical to the RT suites.
hertneky
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime_multrun script option was no longer functional after conversion to DEPHY format-- This was an oversight because the SCM was configured to calculate runtime from the begin/end date in the DEPHY files, ignoring whatever was in the case configuration namelist. In addition, runtime_mult is a run script-only function. Previously, it was simply used to modify the existing case configuration runtime, but for DEPHY cases, runtime wasn't even being provided in the case configuration namelists and would have been ignored anyway by the SCM.
-- These changes move the
runtime_multnamelist option to be read in by the SCM if available.-- The runtime listed in the case configuration namelist will be used (if given) even when the case uses the DEPHY format.
--
runtime_multis used to modify the runtime in the SCM code, whether runtime comes from the case configuration namelist OR is calculated from the DEPHY file.