Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheyenne to Derecho Script and Documentation Update #487

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Cheyenne to Derecho Script and Documentation Update #487

merged 1 commit into from
Jul 29, 2024

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Jun 6, 2024 •
edited
Loading

Updating scripts and documentation to reflect NCAR's move from Cheyenne to Derecho clusters. Need to find the paths to UFS_RTs on Derecho and then the PR will be moved from draft to ready for review.

  • update Cheyenne scratch paths

Paths that were updated

scm/etc/scripts/GABLS3_LSM.ncl:;  gl_dir = "/glade/scratch/damico/GLDAS_GABLS3/"
scm/etc/scripts/GABLS3_LSM_RUC.ncl:;  gl_dir = "/glade/scratch/damico/GLDAS_GABLS3/"
scm/etc/scripts/GABLS3_LSM_NoahMP.ncl:;  gl_dir = "/glade/scratch/damico/GLDAS_GABLS3/"
scm/doc/TechGuide/chap_cases.rst:   ./UFS_forcing_ensemble_generator.py -d /glade/scratch/epicufsrt/GMTB/CCPP-SCM/UFS_RTs/control_c192/ -sc --C_RES 192 -dt 360  -n control_c
192 -lons 300 -lats 34
scm/doc/TechGuide/chap_cases.rst:   ./UFS_forcing_ensemble_generator.py -d /glade/scratch/epicufsrt/GMTB/CCPP-SCM/UFS_RTs/control_c384/ -sc --C_RES 384 -dt 225 -n control_c3
84 -lons 300 300 300 300 -lats 34 35 35 37
scm/doc/TechGuide/chap_cases.rst:   ./UFS_forcing_ensemble_generator.py -d /glade/scratch/epicufsrt/GMTB/CCPP-SCM/UFS_RTs/control_p8/ -sc --C_RES 96 -dt 720 -n control_p8 -l
onl 300 320 -latl 40 50 -nens 10 -sdf SCM_GFS_v17_p8

@scrasmussen scrasmussen marked this pull request as draft June 12, 2024 19:13
@scrasmussen scrasmussen marked this pull request as ready for review June 12, 2024 19:31
mkavulich
mkavulich reviewed Jul 10, 2024
View reviewed changes
scm/doc/TechGuide/chap_cases.rst Outdated
staged UWM RTs located at:

- Cheyenne ``/glade/scratch/epicufsrt/GMTB/CCPP-SCM/UFS_RTs``
- Derecho ``/glade/scratch/epicufsrt/GMTB/CCPP-SCM/UFS_RTs``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this directory was never ported over from Cheyenne before it was scrubbed. @dustinswales Does it make sense to grab some examples from the WM baselines Derecho and ask EPIC to stage them in a similar Derecho directory? Does it matter which tests we use?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to more generic /glade/derecho/scratch/epicufsrt/FV3_RT/ which does exist

scm/doc/TechGuide/chap_cases.rst Outdated
@@ -520,7 +520,7 @@ UFS regression test, ``control_c192``, for single point.

.. code:: bash

./UFS_forcing_ensemble_generator.py -d /glade/scratch/epicufsrt/GMTB/CCPP-SCM/UFS_RTs/control_c192/ -sc --C_RES 192 -dt 360 -n control_c192 -lons 300 -lats 34
./UFS_forcing_ensemble_generator.py -d /glade/derecho/scratch/epicufsrt/ufs-weather-model/RT/NEMSfv3gfs/develop-20240607/control_c192_intel/ -sc --C_RES 192 -dt 360 -n control_c192 -lons 300 -lats 34
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want to use these directories since they are scrubbed on a semi-regular basis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to more generic ./UFS_forcing_ensemble_generator.py -d [path_to_regression_tests_output]/control_c192_intel/ -sc --C_RES 192 -dt 360 -n control_c192 -lons 300 -lats 34

scm/etc/scm_qsub_example.py
@@ -3,10 +3,15 @@
-----------------------------------------------------------------------
Description: Example script to submit a job through the HPC batch system

Assumptions: For use on Cheyenne. This script must be copied to the bin directory.
Assumptions: For use on Derecho. This script must be copied to the bin directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on Derecho? I don't think I ever tried out this example script in my Derecho testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generalized this script more, testing right now, thanks for your input!

scm/etc/scripts/GABLS3_LSM.ncl
@@ -5,7 +5,7 @@ load "$NCARG_ROOT/lib/ncarg/nclscripts/csm/contributed.ncl"
begin

;Define constants

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still supporting NCL scripts? 😱

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I'm not sure if we officially support them. I didn't try them, only changed Cheyenne -> Derecho and the editor automatically cleaned up the trailing whitespace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only ever run these scripts once on my local machine. They're not really meant to be run again and are saved in the repo in case there is a mistake in the forcing file and need to be regenerated. I don't think we need to "support" this to anyone but ourselves. This goes for most of the the "leftover" scripts in etc/scripts. This should probably be cleaned up at some point.

grantfirl
grantfirl approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please pull in the latest main before we push the merge button.

@scrasmussen
Copy link
Member Author

Looks good to me. Please pull in the latest main before we push the merge button.

Thanks for the review, just pulled in the latest main 👍

@grantfirl grantfirl merged commit 7e7959d into NCAR:main Jul 29, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkavulich mkavulich mkavulich left review comments

@grantfirl grantfirl grantfirl approved these changes

@dustinswales dustinswales Awaiting requested review from dustinswales dustinswales is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scrasmussen @mkavulich @grantfirl