Add COMBLE case to CCPP SCM #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing data was provide by COMBLE-MIP Project (https://github.com/ARM-Development/comble-mip/blob/main/notebooks/forcing/COMBLE_INTERCOMPARISON_FORCING_V2.4.nc) @bluefinweiwei modify the forcing data and scm_input.F90 to work with CCPP SCM new file: ../data/processed_case_input/COMBLE_SCM_driver.nc new file: ../etc/case_config/COMBLE.nml modified: scm_input.F90
bluefinweiwei
requested review from
dustinswales,
grantfirl and
mkavulich
as code owners
grantfirl
reviewed
Jul 31, 2024
| @@ -1630,7 +1630,7 @@ subroutine get_case_init_DEPHY(scm_state, scm_input) | |||
| call NetCDF_read_var(ncid, "wprvp_s", .False., input_force_wprvp) | |||
| call NetCDF_read_var(ncid, "wprtp_s", .False., input_force_wprtp) | |||
| else if (trim(input_surfaceForcingMoist) == 'surface_flux') then | |||
| call NetCDF_read_var(ncid, "hfls", .False., input_force_sfc_lat_flx) | |||
| call NetCDF_read_var(ncid, "hfls", .False., input_force_sfc_sens_flx) | |||
There was a problem hiding this comment.
@bluefinweiwei What is the reason for this change? hfls is supposed to be the surface latent heat flux, not sensible.
There was a problem hiding this comment.
@grantfirl This change should be discarded. About this line, yes, you're right that it should be "lat" not "sens". Also, any change for this line is actually not necessary for COMBLE, since its surface forcing is surface temperature "ts" not heat fluxes. I am not sure why this was not updated and pushed, which might be a mistake by me. Sorry for the confusion!
Merged
|
Combined into #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing data: ../data/processed_case_input/COMBLE_SCM_driver.nc
Case config file: ../etc/case_config/COMBLE.nml
Modified: scm_input.F90
attn: @hertneky @dustinswales @grantfirl @lulinxue