Skip to content

Commit

Permalink
Changes recommended by Mike K. to simplify default mpi_command logic
Browse files Browse the repository at this point in the history
  • Loading branch information
scrasmussen committed Sep 5, 2024
1 parent de0a9ce commit 9eb5ab4
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions scm/src/run_scm.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
parser.add_argument('--stop_on_error', help='when running multiple SCM runs, stop on first error', required=False, action='store_true')
parser.add_argument('-v', '--verbose', help='set logging level to debug and write log to file', action='count', default=0)
parser.add_argument('-f', '--file', help='name of file where SCM runs are defined')
parser.add_argument('--mpi_command', help='command used to invoke the executable via MPI (including options)', required=False, default=False)
parser.add_argument('--mpi_command', help='command used to invoke the executable via MPI (including options)', required=False, default='')

###############################################################################
# Functions and subroutines #
Expand Down Expand Up @@ -724,9 +724,6 @@ def setup_rundir(self):
def launch_executable(use_gdb, gdb, mpi_command, ignore_error = False):
"""Configure model run command and pass control to shell/gdb"""

# If mpi_command flag not passed default to '' to allow it to run on login nodes
if not mpi_command:
mpi_command = ''
if use_gdb:
if mpi_command != '' and ('xterm' not in mpi_command):
logging.info("run_scm.py debug flag adds 'xterm -e' to MPI command")
Expand Down

0 comments on commit 9eb5ab4

Please sign in to comment.