Fix/smarter disabling #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension must be defined (this is determined by the `configure` script), and it must not be disabled (this is done by the user on the command line using e.g. `--disable-avx`).
…flags Instead, look at the test results and allow the user to disable the vector extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the user-accessible logic in the
configurescript, ensuring that if a user uses e.g.--disable-sse, all SSE code paths are removed and no SSE-related compiler flags are used. Likewise for--disable-avxand--disable-fma.This fixes the issue that occurs if a user compiles the code on one system that supports SSE, AVX, and FMA, but runs it on another system which does not have one or several of these extensions. Previously, the code would always be compiled with the associated
-moptions if the build system supported them (even if the associated code paths were disabled), leading to binaries that could not be used on the target system.This PR closes #261
This PR closes #194
This PR closes #276