-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #199 - Upgrade to Python 3.10 #201
base: master
Are you sure you want to change the base?
Conversation
@christianmkuss When running the tests, I am seeing an error related to collections.Callable
|
Hmm, looks like nose is no longer maintained and doesn't support Python 3.9+ (nose-devs/nose#1099). I was able to run the tests with with nose.tools.assert_raises(ImportError): in with pytest.raises(ImportError): If you want to fully transition to pytest and drop nose I can add that to this PR. Otherwise I don't think there is a way to run the tests with 3.10. |
@christianmkuss I believe our plan is to fully transition to pytest (as part of transitioning the GUI and DSN to poetry builds). So yes, if you wouldn't mind including those changes with the PR, we would appreciate it. Thanks |
Because of the strictly pinned versions this library would only work with Python 3.7, as stated in the documentation. Since the dependencies are well founded they provide support for newer versions of Python, including Python 3.10. By migrating to the newer versions this library will now support Python3.10 but drop support for other versions. Nose is no longer maintained and does not support 3.9+. This commit removes nose as a dependency in favor of pytest. Fixes NASA-AMMOS#199
fc32f22
to
d8f3a05
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Because of the strictly pinned versions this library would only work with Python 3.7, as stated in the documentation. Since the dependencies are well founded they provide support for newer versions of Python, including Python 3.10. By migrating to the newer versions this library will now support Python3.10 but drop support for other versions.
Fixes #199