Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neato #1477

Open
wants to merge 1 commit into
base: 20.08
Choose a base branch
from
Open

Add neato #1477

wants to merge 1 commit into from

Conversation

AZAZ78
Copy link

@AZAZ78 AZAZ78 commented Feb 14, 2021

Info

This PR adds the new skill, neato, to the skills repo.

Description

This skill allows you to control your vacuum cleaner robot with your voice. Lay back on your coach and tell your Neato to start cleaning the house or single rooms.
Also room specific NoGo Lines are supported by persistend maps (can be configured in your corresponding vacuum cleaner app)

You have to provide the name of your robot, its serial number and its secret. You can get those information by executing credentials.py from the skill directory.
To persist your credentials you can directly tell the script to persist them.

If you want to clean explicit rooms with NoGo Lines, you have to specify them in the optional rooms setting in json format (example is already provided). To get the right map id for your persistent maps there is another helper-script in the skill directory called getmapid.py

Created with mycroft-skills-kit v0.3.16

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@AZAZ78
Copy link
Author

AZAZ78 commented Feb 18, 2021

Hi, i saw in the CI pipeline that the neato test is failing. This is obviously because of the missing configuration in the test environment. How can i manage this without coding my personal access credentials in the test?

@krisgesling
Copy link
Contributor

Hey Azaz, unfortunately the mocking options are limited in our Voight Kampff test suite so far.

I had a quick look at the code and tbh the easiest option would be to expect the error dialog. This at least confirms that the Skill is loading, and the intent is triggering as expected.

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

1 similar comment
@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Skill submission
Development

Successfully merging this pull request may close these issues.

3 participants