Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Add CaffeineWiz #1466

Closed
wants to merge 1 commit into from
Closed

Conversation

NeonDaniel
Copy link
Member

Info

This PR adds the new skill, CaffeineWiz, to the skills repo.

Description

The skill provides the functionality to inform the user of the caffeine content of the requested drink by collecting the required information from two data sources:

  1. http://caffeinewiz.com/ - the main source of information for the drink’s database
  2. https://www.caffeineinformer.com/the-caffeine-database - secondary source for any non-duplicate drinks

CaffeineWiz uses BeautifulSoup to pull the tables from the websites above, then strips the html tags, and later formats the results into the comprehensive list. That object is pickled for the future use.

The skill will check for updates periodically. You can modify that time period by changing TIME_TO_CHECK parameter on top of the file in the init.

Created with mycroft-skills-kit v0.3.15

@NeonDaniel NeonDaniel mentioned this pull request Jan 14, 2021
@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@NeonDaniel
Copy link
Member Author

It appears that msk submitted the "master" branch or my repository, though I had the "dev" branch checked out in the local directory I called msk submit from. Is this expected behavior?

@krisgesling
Copy link
Contributor

I'd have to double check but I think it takes the default branch of the repo at the moment.

For the Marketplace, given they're submodules it doesn't have to be from the default branch that's likely just a limitation of MSK for the moment. You can also submit a PR updating the submodule manually, they're just notoriously annoying to deal with.

@NeonDaniel
Copy link
Member Author

Okay, default branch makes some sense, though it could be a nice addition for that to be specified in the CLI when submitting a change.

I agree msk does make dealing with getting the correct submodule changes in the repo a lot simpler.

@devops-mycroft
Copy link
Collaborator

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@krisgesling
Copy link
Contributor

Just to reassure - the reported test failures are not caused by your Skill, I'm working on that currently.

@krisgesling krisgesling added needs validation Needs validatiion by another Skills Team Member or Community Member trying it new New Skill (not update to existing Skill) labels Jan 14, 2021
@NeonDaniel
Copy link
Member Author

Okay, I noticed the failures didn't appear to involve my skill and all recently submitted skills seem to be affected. Let me know if there is anything I need to address.

@forslund
Copy link
Collaborator

forslund commented Nov 5, 2024

Project is no longer maintained, closing.

@forslund forslund closed this Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs validation Needs validatiion by another Skills Team Member or Community Member trying it new New Skill (not update to existing Skill)
Projects
No open projects
Status: Skill submission
Development

Successfully merging this pull request may close these issues.

4 participants