Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

add VIC nodes.js #2119

Open
wants to merge 1 commit into
base: mercury
Choose a base branch
from

Conversation

Victorium-org
Copy link
Contributor

No description provided.

@gamalielhere
Copy link
Collaborator

@Victorium-org Is there any reason why your chainID doesn't match what the net_version return?

@Victorium-org
Copy link
Contributor Author

Protocol Versions: [63 62], Network Id: 93610431, Chain Id: 4388577777

@gamalielhere
Copy link
Collaborator

@Victorium-org okay cool. Do you mind syncing your branch to the mercury branch? The ci test need to pass before I can merge it.

@Victorium-org
Copy link
Contributor Author

what i need to do now ?

@gamalielhere
Copy link
Collaborator

@Victorium-org merge our current mercury branch with your local one so it's in sync. That should fix the CI error.

@hackmod
Copy link
Contributor

hackmod commented Nov 11, 2018

chainId 4388577777 : https://github.com/VictoriumProject/go-victorium/blob/master/core/config/mainnet.json#L40

no bip44 entry found for victorium.

travis error: Cannot find module './abiDefinitions/vicAbi.json'

and currently, not a working node.

curl --header Content-Type: application/json -X POST --data {"jsonrpc":"2.0","method":"net_version","params":[],"id":1} https://node.victorium.org:8555
curl: (7) Failed to connect to node.victorium.org port 8555: Connection refused

@mkrufky
Copy link
Contributor

mkrufky commented Nov 13, 2018

@gamalielhere I don't think this should be merged without SLIP44 registration. I'd recommend to remove your approval from the PR.

@gamalielhere
Copy link
Collaborator

@mkrufky thanks for the heads up, unfortunately, I don't think I can remove my approval. I'll hold off on merging this until it gets added to bip44 and if the node is back up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants