Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Support configurable settings #2041

Open
wants to merge 3 commits into
base: mercury
Choose a base branch
from

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Aug 30, 2018

  • separate configurable variables to the config.default.json
  • read local config.json to override default variables

There are several MyEtherWallet based well-known clone sites exist like as

some wallets are updated frequently based on the latest MyEtherWallet but not all of them frequently updated.

This PR makes clone sites more likely maintainable.

Done

  • extract configurable variables to config.default.json
  • customLess option : append selected customLess file
  • configurable network list using gulp prep --networks eth_ethscan,pirl command

config.default.json

{
  "selected": "mew",
  "mew": {
    "custom": false,
    "showDontGetPhished": true,
    "showPrefooterWarning": true,
    "showMewAdSites": true,
    "showDonation": true,
    "showTranslators": true,
    "showMewSites": true,
    "showGithub": true,
    "showExtensions": true,
    "googleSiteVerification": "IpChQ00NYUQuNs_7Xs6xlnSdzalOlTUYbBsr8f7OpvM",
    "legalname": "MyEtherWallet Inc",
    "sitename": "MyEtherWallet",
    "sitetitle": "Your Key to Ethereum",
    "sitehost": "MyEtherWallet.com",
    "siteurl": "https://www.myetherwallet.com",
    "email": "[email protected]",
    "description": "MyEtherWallet (MEW) is a free, open-source, client-side interface for generating Ethereum wallets & more. Interact with the Ethereum blockchain easily & securely.",
    "descriptionFixed": "MyEtherWallet.com is a free, open-source, client-side interface for generating Ethereum wallets & more. Interact with the Ethereum blockchain easily & securely.",
    "shortDescription": "Free, open-source, client-side Ethereum wallet. Enabling you to interact with the blockchain easily & securely.",
    "appTitle": "MyEtherWallet · Your Key to Ethereum",
    "themecolor": "#1d6986",
    "maskcolor": "#2f99b0",
    "twitterid": "@MyEtherWallet",
    "sitelogo": "logo-myetherwallet.svg",
    "sitelogocx": "logo-myetherwalletcx.svg",
    "poweredby": "logo-myetherwallet.svg",
    "logourl" : "https://www.myetherwallet.com/images/myetherwallet-logo.png",
    "copyright": "© 2018 MyEtherWallet, Inc",
    "instagram": "https://instagram.com/myetherwallet",
    "reddit": "https://www.reddit.com/r/MyEtherWallet/",
    "twitter": "https://twitter.com/myetherwallet",
    "facebook": "https://www.facebook.com/MyEtherWallet/",
    "medium": "https://medium.com/@myetherwallet",
    "linkedin": "https://www.linkedin.com/company/myetherwallet",
    "support": "mailto:[email protected]",
    "github": "https://github.com/MyEtherWallet"
 }

@hackmod hackmod force-pushed the configurable-settings branch 8 times, most recently from db04a15 to a48ac47 Compare September 5, 2018 02:48
* separate configurable variables to the config.default.json
* read local config.json to override default variables
 * use `gulp prep --networks eth_mew,blah,blah` command to show selected networks only
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant