This repository has been archived by the owner on May 9, 2022. It is now read-only.
Issue #6: String resource conversion #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,7 +105,7 @@ public void populateViewHolder(Holder holder) { | |||
| // Redo name | |||
| String name = getName(); | |||
| if (getOpenStatus() == RestaurantOpenStatus.Closed) { | |||
| name += " [Closed]"; | |||
| name += getString(R.string.brackets_closed); | |||
| } | |||
|
|
|||
| holder.name.setText(name); | |||
There was a problem hiding this comment.
Below here is dollars += "D" single character for hasDelivery(). Did you want this as a string resource as well?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted UI displayed strings to string resources. Resolves #6
Do not merge until this is loaded with an appropriate IDE to generate related R files as well
Notes
noalertanderror. I am unsure that they are displayed to the user.Please let me know if any of these are wrong and I will correct this if necessary