Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply renames from remaster #177

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

MaienM
Copy link
Contributor

@MaienM MaienM commented Feb 29, 2024

I noticed that some of the name changes in the remaster had not yet been applied, so I went ahead and did some quick scripting to update these.

@MaienM MaienM force-pushed the remaster-renames branch 2 times, most recently from 9893acb to b3b1229 Compare February 29, 2024 00:41
@MrVauxs
Copy link
Owner

MrVauxs commented Feb 29, 2024

Can you clone the animations instead of rewriting them so both versions are supported? Thanks!

@MaienM
Copy link
Contributor Author

MaienM commented Feb 29, 2024

Done. The diff's a bit of a mess as it interprets a lot of the changes in autorec.json as changes to existing objects rather than additions, this tool does a much better job.

For the macros I've just added extra case statements to the switches, so

switch (spellName) {
	case "inspire-courage": {
		new Sequence({moduleName: "PF2e Animations", softFail: true}).play();
		break;
	}
}

turn into

switch (spellName) {
	case "inspire-courage":
	case "courageous-anthem": {
		new Sequence({moduleName: "PF2e Animations", softFail: true}).play();
		break;
	}
}

@MrVauxs
Copy link
Owner

MrVauxs commented Feb 29, 2024

Appreciate it, thank you!

@MrVauxs MrVauxs merged commit 74eadb4 into MrVauxs:master Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants