Update TestCase.load() to load in place #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tysmith
commented
Nov 21, 2023
tysmith
commented
- Remove TestCase.purge_optional since this now happens automatically.
- TestCase.load() now only loads a single test case.
- Break up test case loading in to smaller more testable parts.
tysmith
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 99.59% 99.51% -0.08%
==========================================
Files 50 50
Lines 5481 5408 -73
==========================================
- Hits 5459 5382 -77
- Misses 22 26 +4 ☔ View full report in Codecov by Sentry. |
tysmith
force-pushed
the
testcase-load
branch
3 times, most recently
from
8c5626e
to
6113abc
Compare
|
|
tysmith
force-pushed
the
testcase-load
branch
4 times, most recently
from
3b7737e
to
4d31459
Compare
jschwartzentruber
approved these changes
Nov 24, 2023
- Remove TestCase.purge_optional() since it now automatic. - TestCase.load() now only loads a single test case. - Break up test case loading in to smaller more testable parts. - Update Replay and Reduce to support changes - Fix test leaks
tysmith
force-pushed
the
testcase-load
branch
from
4d31459
to
30542a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.