Use localhost instead of 127.0.0.1 for bootstrapping #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysmith
requested changes
Sep 26, 2023
tysmith
reviewed
Sep 26, 2023
| @@ -45,7 +45,7 @@ def __init__(self): | |||
| self._handler = ReqHandler | |||
| while True: | |||
| try: | |||
| self._httpd = HTTPServer(("127.0.0.1", 0), self._handler) | |||
| self._httpd = HTTPServer(("localhost", 0), self._handler) | |||
There was a problem hiding this comment.
This also does not need to change.
|
Closing this entirely as it's deemed unnecessary and the performance impact on Windows due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required as part of MozillaSecurity/grizzly#374 to ensure that the initial harness page is loaded on
localhostinstead of127.0.0.1. I'm unsure if the disparity between the two will cause cross origin issues or not but there's no harm in changing it.