Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wip implementation for passing chunk state fo wgpu layer #5125

Draft
wants to merge 16 commits into
base: feature/wgpu-rendering-refactor
Choose a base branch
from

Conversation

pollend
Copy link
Member

@pollend pollend commented Jul 25, 2023

Contains

Initial planned changes to support chunk meshes into the rust layer. At the moment I'll just stage the chunk meshes on the java side and pass it to wgpu to manage. I'll start with just filling out the position buffer and I'll add more back in as we construct the pipeline for the scene.

Was thinking about indirect rendering but that will be another challenge to approach later. The problem space would include a custom allocator to allocate everything to a single buffer to bind to the render pipeline.

there is this PR that is associated with this change: MovingBlocks/TeraRusty#8

pollend and others added 16 commits July 23, 2023 17:16
Signed-off-by: Michael Pollind <[email protected]>
…ses`. unitTests and integrationTests works now
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Jul 25, 2023
Comment on lines -83 to -84
public void appendTo(ChunkMesh chunk, ChunkView chunkView, int offsetX, int offsetY, int offsetZ,
ChunkMesh.RenderType renderType, Colorc colorOffset, ChunkVertexFlag flags) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to pass in the RenderType. if we still want the enumeration for the type we can expose that as a free function.

@pollend pollend force-pushed the feature/wgpu-rendering-refactor branch from 221e454 to f3efca5 Compare September 26, 2023 01:06
@jdrueckert jdrueckert added the Status: Needs Author Input Requires more information by the author on the reported issue or provided changes label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Author Input Requires more information by the author on the reported issue or provided changes Type: Improvement Request for or addition/enhancement of a feature
Projects
Status: Next Milestone
Development

Successfully merging this pull request may close these issues.

3 participants