Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TypeHandlerLibrary)! make Serializer more type-safe #5049

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

keturn
Copy link
Member

@keturn keturn commented Jun 15, 2022

I don't know how necessary this is, but it's one of those things where I started pulling on a string while debugging and then I'm all caught up in a game of type-algebra sudoku.

This probably depends on a small change to nui-reflect.

The usage of var is not purely aesthetic here, at least in some cases. There seem to be situations where it gives the type engine room to search more deeply than it does if you use wildcards with local variables yourself.

Outstanding before merging

  • document the places "ignore unchecked" is used
  • rename or inline the inner methods with weird names

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant