improvement: textures scale to size #551
Conversation
There was a problem hiding this comment.
Just some assorted comments here. I did test it and still sank in a bit on the right side of the asteroid, left side seemed fine. Which was about the same last time, but I did really get the latest code for sure, honest!
I seem to recall the exact asteroid picked varies? In which case maybe that explains the subtle differences at times without making changes. I don't want to be an asteroidist but they do kinda all look alike ...
engine/src/main/java/org/destinationsol/asteroids/systems/AsteroidBodyCreationSystem.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/destinationsol/rendering/RenderableElement.java
Show resolved
Hide resolved
engine/src/main/java/org/destinationsol/rendering/RenderableElement.java
Outdated
Show resolved
Hide resolved
| public EventResult onRender(RenderEvent event, EntityRef entity) { | ||
|
|
||
| if (!entity.hasComponent(Invisible.class)) { | ||
| Renderable renderable = entity.getComponent(Renderable.class).get(); | ||
| if (!renderable.isInvisible) { |
There was a problem hiding this comment.
More of a stray thought than important here, but we had talked about this on Discord recently, with the move from an Invisible component to a boolean inside Renderable - one thing I forgot to mention as a nice benefit to having more components is being able to filter on them in the @ReceiveEvent which is a nice way to avoid if statements and keep the handlers simple.
However, in this case being invisible would be the less likely case, it would seem, and we can't test for "Renderable, Position, and Size, but not Invisible" in the annotation anyway 🤔 Hmm, wonder if that would be useful to have. That then might make one think about whether there should be a a Visible component instead but ... then that's essentially Renderable. ECS: A different bicycle than OOP, but both still fall over at times ;-)
There was a problem hiding this comment.
I definitely hear the benefits of booleans in a component and of having separate components. Maybe you can talk about it with @immortius :)
NicholasBatesNZ
changed the title
Description
This fixes the graphics scaling and aligns the sprite with the collision mesh. As of now, it is slightly inaccurate.
Testing
Start the game with a small ship and poke the edges gently to see if the asteroid's meshes are aligned with the sprite. Repeat at a few different sizes.
Outstanding Work
I'm not sure that the multi-sprite renderables work (e.g. a ship with a gun). That needs to be tested and possibly fixed. The collision mesh alignment is also inaccurate, so that needs to be fixed. See issue #552