-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user provided addresses #61
base: development
Are you sure you want to change the base?
Conversation
…f an incorrect python dependency On macOS, this script checks if Python 3.10 is installed and accessible to node-gyp. I ran into a problem trying to `yarn` install, with a system Python version of `3.12.2`, but ran into the error `ModuleNotFoundError: No module named 'distutils'`. Since node-gyp relies on `distutils`, which is removed in Python `3.12`, you need to use a Python version that still includes `distutils`.
How do you propose to protect the address.txt file? Seems like a single point of attack for someone to change all send addresses and just display the right ones. |
I used localStorage, no .txt file. Could probably sign the data with a users wallet as a form of encryption. |
…eedback-for-missing-python3.10-dependency Give mac developers feedback when `yarn` install fails for missing Python 3.10 dependency
Were you able to get this to run locally? I'm assuming so. Having an issue with the build. Might you pull development and test? https://github.com/MorpheusAIs/Lite-Client/actions/runs/8410641765/job/23224325868?pr=61 |
I haven't been able to build dev since cloning. I'll take another look today. |
Added win instructions
Changes for detailed setup on Windows based systems
Update README.md
@qiwi1272 please advise on your finding. I see you've already received the weights from @DavidAJohnston . Please update with a fix to keep the weights. |
hey my bad, been busy getting things running again, have time now to fix this. |
alright, I can build fine locally, hope the tests work. Would it be considered bad practice to generate the question programmatically, and only accept responses matching 'y', 'yes', 'yea'? |
Please post an example that can be tested |
Good idea. Please suggest a solution |
allow user to specify known addresses. similar to 'payees' in a bank app.
allows for more intuitive prompts (see screenshots).
decreases risk for user error when specifying addresses.
if needed, addresses.tsx and corresponding names can be refactored to 'payees' or 'contacts'
If merged, ill request for 2 weights. PR