Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user provided addresses #61

Open
wants to merge 11 commits into
base: development
Choose a base branch
from

Conversation

qiwi1272
Copy link

@qiwi1272 qiwi1272 commented Mar 24, 2024

allow user to specify known addresses. similar to 'payees' in a bank app.
allows for more intuitive prompts (see screenshots).
decreases risk for user error when specifying addresses.

if needed, addresses.tsx and corresponding names can be refactored to 'payees' or 'contacts'

Example Prompt
AddressesView

If merged, ill request for 2 weights. PR

jsnbuchanan and others added 4 commits March 22, 2024 21:05
…f an incorrect python dependency

On macOS, this script checks if Python 3.10 is installed and accessible to node-gyp.

I ran into a problem trying to `yarn` install, with a system Python version of `3.12.2`, but ran into the error `ModuleNotFoundError: No module named 'distutils'`. Since node-gyp relies on `distutils`, which is removed in Python `3.12`, you need to use a Python version that still includes `distutils`.
@betterbrand
Copy link
Contributor

How do you propose to protect the address.txt file? Seems like a single point of attack for someone to change all send addresses and just display the right ones.

@qiwi1272
Copy link
Author

qiwi1272 commented Mar 26, 2024

How do you propose to protect the address.txt file? Seems like a single point of attack for someone to change all send addresses and just display the right ones.

I used localStorage, no .txt file. Could probably sign the data with a users wallet as a form of encryption.
In my opinion localStorage is considered safe, another option would be httpOnly cookies, but because the server is local: the security increase would be minimal.

…eedback-for-missing-python3.10-dependency

Give mac developers feedback when `yarn` install fails for missing Python 3.10 dependency
@betterbrand
Copy link
Contributor

betterbrand commented Mar 29, 2024

Were you able to get this to run locally? I'm assuming so. Having an issue with the build. Might you pull development and test?

https://github.com/MorpheusAIs/Lite-Client/actions/runs/8410641765/job/23224325868?pr=61

@qiwi1272
Copy link
Author

qiwi1272 commented Mar 30, 2024

Were you able to get this to run locally? I'm assuming so. Having an issue with the build. Might you pull development and test?

https://github.com/MorpheusAIs/Lite-Client/actions/runs/8410641765/job/23224325868?pr=61

I haven't been able to build dev since cloning.
This builds when merged with main, but i figured it might not belong there yet.

I'll take another look today.

Added win instructions
@betterbrand betterbrand changed the base branch from development to main April 5, 2024 19:09
@betterbrand betterbrand changed the base branch from main to development April 5, 2024 19:14
xfactor20 and others added 2 commits April 5, 2024 15:10
Changes for detailed setup on Windows based systems
@betterbrand
Copy link
Contributor

@qiwi1272 please advise on your finding. I see you've already received the weights from @DavidAJohnston . Please update with a fix to keep the weights.

@qiwi1272
Copy link
Author

qiwi1272 commented May 6, 2024

@qiwi1272 please advise on your finding. I see you've already received the weights from @DavidAJohnston . Please update with a fix to keep the weights.

hey my bad, been busy getting things running again, have time now to fix this.
the build error with is every line of prompts.ts, which I didn't change, hopefully just a parsing error.

@qiwi1272
Copy link
Author

qiwi1272 commented May 6, 2024

alright, I can build fine locally, hope the tests work.
David used this feature as an example in the podcast, he said the model would ask to make sure it has the right address for 'bob'.
That's what ill work on next, as it solves the security issue.

Would it be considered bad practice to generate the question programmatically, and only accept responses matching 'y', 'yes', 'yea'?
I only ask because using a model for a yes/no question could be a burden on the user-end.

@betterbrand
Copy link
Contributor

Please post an example that can be tested

@betterbrand
Copy link
Contributor

Would it be considered bad practice to generate the question programmatically, and only accept responses matching 'y', 'yes', 'yea'?

I only ask because using a model for a yes/no question could be a burden on the user-end.

Good idea. Please suggest a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants