Skip to content

Commit

Permalink
Remove all codes for kakao share
Browse files Browse the repository at this point in the history
  • Loading branch information
fornewid committed Oct 26, 2024
1 parent c4cdfbd commit c350cb0
Show file tree
Hide file tree
Showing 14 changed files with 1 addition and 206 deletions.
2 changes: 0 additions & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ dependencies {

implementation libs.androidx.profileinstaller

implementation libs.kakao.share

testImplementation projects.testing
androidTestImplementation projects.testing
androidTestImplementation libs.androidx.benchmark.macro.junit4
Expand Down
8 changes: 1 addition & 7 deletions app/dependencies/releaseRuntimeClasspath.txt
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ com.google.android.gms:play-services-measurement:22.0.0
com.google.android.gms:play-services-stats:17.0.2
com.google.android.gms:play-services-tasks:18.1.0
com.google.code.findbugs:jsr305:3.0.2
com.google.code.gson:gson:2.8.9
com.google.code.gson:gson:2.8.6
com.google.dagger:dagger-lint-aar:2.52
com.google.dagger:dagger:2.52
com.google.dagger:hilt-android:2.52
Expand Down Expand Up @@ -185,18 +185,12 @@ com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
com.google.j2objc:j2objc-annotations:1.3
com.google.protobuf:protobuf-javalite:3.21.11
com.jakewharton.timber:timber:5.0.1
com.kakao.sdk:v2-common:2.20.1
com.kakao.sdk:v2-network:2.20.1
com.kakao.sdk:v2-share:2.20.1
com.kakao.sdk:v2-template:2.20.1
com.naver.maps:geometry:1.3.0
com.naver.maps:map-sdk:3.18.0
com.squareup.okhttp3:logging-interceptor:4.9.2
com.squareup.okhttp3:okhttp-brotli:4.10.0
com.squareup.okhttp3:okhttp:4.12.0
com.squareup.okio:okio-jvm:3.8.0
com.squareup.okio:okio:3.8.0
com.squareup.retrofit2:converter-gson:2.9.0
com.squareup.retrofit2:converter-kotlinx-serialization:2.11.0
com.squareup.retrofit2:retrofit:2.11.0
com.webtoonscorp.android:readmore-foundation:1.5.6
Expand Down
4 changes: 0 additions & 4 deletions app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@
-dontwarn android.support.**
-dontwarn androidx.**

# Kakao SDK
-keep class com.kakao.sdk.**.model.* { <fields>; }
-keep class * extends com.google.gson.TypeAdapter

# Crashlytics
-keep class com.crashlytics.** { *; }
-dontwarn com.crashlytics.**
Expand Down
4 changes: 0 additions & 4 deletions app/src/debug/res/values/credentials.xml

This file was deleted.

9 changes: 0 additions & 9 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@
<meta-data
android:name="firebase_crashlytics_collection_enabled"
android:value="${crashlytics_enabled}" />
<meta-data
android:name="com.kakao.sdk.AppKey"
android:value="@string/kakao_app_key" />
<meta-data
android:name="com.naver.maps.map.CLIENT_ID"
android:value="@string/naver_map_sdk_client_id" />
Expand All @@ -61,9 +58,6 @@
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data
android:host="kakaolink"
android:scheme="@string/kakao_scheme" />
<data
android:host="moop.link"
android:scheme="https" />
Expand All @@ -81,9 +75,6 @@
<meta-data
android:name="soup.movie.startup.LoggerInitializer"
android:value="androidx.startup" />
<meta-data
android:name="soup.movie.startup.KakaoInitializer"
android:value="androidx.startup" />
</provider>

<meta-data
Expand Down
32 changes: 0 additions & 32 deletions app/src/main/java/soup/movie/startup/KakaoInitializer.kt

This file was deleted.

5 changes: 0 additions & 5 deletions app/src/main/java/soup/movie/ui/main/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import soup.movie.config.RemoteConfig
import soup.movie.core.designsystem.theme.MovieTheme
import soup.movie.core.designsystem.windowsizeclass.calculateWindowSizeClass
import soup.movie.feature.deeplink.FirebaseLink
import soup.movie.feature.deeplink.KakaoLink
import soup.movie.feature.tasks.RecommendMoviesTasks
import javax.inject.Inject

Expand Down Expand Up @@ -79,10 +78,6 @@ class MainActivity : AppCompatActivity() {
FirebaseLink.extractMovieId(intent) { movieId ->
if (movieId != null) {
viewModel.requestMovie(movieId)
} else {
KakaoLink.extractMovieId(intent)?.let {
viewModel.requestMovie(it)
}
}
}
}
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values/credentials.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="kakao_app_key" translatable="false">56edfbbe3bc2086b8a1f8eb198456ae8</string>
<string name="kakao_scheme" translatable="false">kakao56edfbbe3bc2086b8a1f8eb198456ae8</string>
<string name="naver_map_sdk_client_id" translatable="false">prd264z8ie</string>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ object MovieIcons {
val LoadingLogo = R.drawable.ic_loading_logo
val Facebook = R.drawable.ic_logo_facebook
val Instagram = R.drawable.ic_logo_instagram
val KakaoTalk = R.drawable.ic_logo_kakaotalk
val Line = R.drawable.ic_logo_line
val More = R.drawable.ic_logo_more
val Twitter = R.drawable.ic_logo_twitter
Expand Down
30 changes: 0 additions & 30 deletions core/designsystem/src/main/res/drawable/ic_logo_kakaotalk.xml

This file was deleted.

2 changes: 0 additions & 2 deletions feature/deeplink/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,4 @@ dependencies {

implementation platform(libs.firebase.bom)
implementation libs.firebase.dynamiclinks

implementation libs.kakao.share
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import androidx.core.app.ShareCompat
import soup.movie.core.designsystem.icon.MovieIcons
import soup.movie.core.designsystem.theme.MovieTheme
import soup.movie.feature.deeplink.FirebaseLink
import soup.movie.feature.deeplink.KakaoLink
import soup.movie.model.MovieModel
import soup.movie.resources.R

Expand Down Expand Up @@ -135,23 +134,6 @@ internal fun DetailShare(
)
}
}
IconButton(
onClick = {
context.shareToKakaoTalk(movie)
},
modifier = Modifier.padding(top = 4.dp),
) {
Surface(
shape = CircleShape,
modifier = Modifier.requiredSize(48.dp).padding(all = 4.dp),
) {
Image(
painterResource(MovieIcons.KakaoTalk),
contentDescription = null,
modifier = Modifier.fillMaxSize(),
)
}
}
IconButton(
onClick = {
context.shareToOthers(movie)
Expand All @@ -172,28 +154,6 @@ internal fun DetailShare(
}
}

private fun Context.shareToKakaoTalk(movie: MovieModel) {
KakaoLink.share(
context = this,
movieId = movie.id,
imageUrl = movie.posterUrl,
title = movie.title,
description = buildString {
append(movie.openDate)
val ageLabel = getString(
when {
movie.age >= 19 -> R.string.movie_age_19
movie.age >= 15 -> R.string.movie_age_15
movie.age >= 12 -> R.string.movie_age_12
movie.age >= 0 -> R.string.movie_age_all
else -> R.string.movie_age_unknown
},
)
append(" / $ageLabel")
},
)
}

private fun Context.shareToFacebook(movie: MovieModel) {
shareText(movie, "com.facebook.katana")
}
Expand Down
2 changes: 0 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ coil = "2.6.0"
dependencyGuard = "0.5.0"
retrofit = "2.11.0"
timber = "5.0.1"
kakao = "2.20.1"


[libraries]
Expand Down Expand Up @@ -152,7 +151,6 @@ coil-compose = { module = "io.coil-kt:coil-compose", version.ref = "coil" }
retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
retrofit-serialization = { module = "com.squareup.retrofit2:converter-kotlinx-serialization", version.ref = "retrofit" }

kakao-share = { module = "com.kakao.sdk:v2-share", version.ref = "kakao" }
timber = { module = "com.jakewharton.timber:timber", version.ref = "timber" }


Expand Down

0 comments on commit c350cb0

Please sign in to comment.