Fix R8 issues temporarily

Moop-App · Dec 9, 2023 · 8cfc90d · 8cfc90d
1 parent b8e7337
commit 8cfc90d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -28,4 +28,4 @@ jobs:
           java-version: 17
 
       - name: Build, lint and spotless
-        run: ./gradlew spotlessCheck dependencyGuard assemble lintDebug --scan
+        run: ./gradlew spotlessCheck dependencyGuard lintDebug assemble --scan
diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro
@@ -39,9 +39,6 @@
 -dontwarn org.jetbrains.annotations.**
 -keep class kotlin.Metadata { *; }
 
-# For dynamic-features module
--keep class soup.movie.theatermap.** { *; }
-
 # For kotlinx.serialization
 -keepattributes *Annotation*, InnerClasses
 -dontnote kotlinx.serialization.SerializationKt

diff --git a/build-logic/convention/src/main/kotlin/soup/movie/buildlogic/Kotlin.kt b/build-logic/convention/src/main/kotlin/soup/movie/buildlogic/Kotlin.kt
@@ -13,6 +13,9 @@ fun Project.configureKotlin() {
             freeCompilerArgs = freeCompilerArgs + listOf(
                 "-opt-in=kotlin.RequiresOptIn",
                 "-opt-in=kotlinx.coroutines.ExperimentalCoroutinesApi",
+
+                // https://github.com/Kotlin/kotlinx.serialization/issues/2145#issuecomment-1653091753
+                "-Xstring-concat=inline",
             )
         }
     }

diff --git a/gradle.properties b/gradle.properties
@@ -28,6 +28,11 @@ kapt.include.compile.classpath=false
 # Non-transitive R classes is recommended and is faster/smaller
 android.nonTransitiveRClass=true
 
+# Default values changed on AGP 8.0
+# https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes#default-changes
+android.nonFinalResIds=false
+android.enableR8.fullMode=false
+
 # Default build features
 android.defaults.buildfeatures.buildconfig=false
 android.defaults.buildfeatures.aidl=false