-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for transfer_assets_using_type_and_then
extrinsic in pallet-xcm precompile
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
reviewed
Oct 3, 2024
librelois
reviewed
Oct 3, 2024
librelois
reviewed
Oct 4, 2024
librelois
reviewed
Oct 4, 2024
librelois
reviewed
Oct 4, 2024
librelois
reviewed
Oct 4, 2024
librelois
reviewed
Oct 4, 2024
librelois
reviewed
Oct 4, 2024
librelois
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Agusrodri Overall it's good, can you just explain in the solidity doc that customXcmOnDest
should be SCALE encoded?
Agusrodri
added a commit
that referenced
this pull request
Oct 8, 2024
…llet-xcm precompile (#54) * start adding transfer_assets_using_type_and_then to pallet-xcm precompile * add function variant for address type * use WeightLimit::Unlimited in all selectors * add remaining functions and overall refactor * remove unnecessary selectors and add a couple tests * add more tests * pr suggestions * add documentation for solidity selectors * fmt * fix test * fix rust tests compilation * add clarification for SCALE encoding in custom xcm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds support for
transfer_assets_using_type_and_then
extrinsic in pallet-xcm precompile.In total 4 new selectors were added to the pallet-xcm precompile interface:
8425d893
:This function allows calling
transfer_assets_using_type_and_then
extrinsic (with assets being represented inLocation
format) by ONLY allowing combinations ofLocalReserve
,Teleport
, andDestinationReserve
transfer types.RemoteReserve
type is not allowed here. It was decided to split the behavior in two functions for better params organization.fc19376c
:This function allows calling
transfer_assets_using_type_and_then
extrinsic (with assets being represented inLocation
format) through theRemoteReserve
transfer type for both assets and fees. In this case, assets and fees MUST share the same reserve for the extrinsic to execute properly. This is being restricted by pallet-xcm, as it doesn't allow to send XCMs to separate chains, given that there is no guarantee of delivery order on final destination (more details here).998093ee
andaaecfc62
) are identical to the ones described above. The only difference is that they receive the assets inAddress
format.Related upstream PRs