Add non_color_options to mcprep base data json #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's another "one more thing" sort of thing, but the automated release script takes a step to refresh the json update. That is done via the line
python mcprep_data_refresh.py -auto
in the push_latest script. This pulls data frommcprep_base_data.json
file before dynamically filling out the remaining values from Mineways/jmc2obj latest master versions & the latest local Minecraft game jar.Before this change, I had auto committed the refresh mappings (as I often do) and then saw errors like these in automated tests:
Now all is resolved: