-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Build Support #605
Debug Build Support #605
Conversation
Signed-off-by: Mahid Sheikh <[email protected]>
Signed-off-by: Mahid Sheikh <[email protected]>
Signed-off-by: Mahid Sheikh <[email protected]>
Signed-off-by: Mahid Sheikh <[email protected]>
Just glancing through, I see this also represents embracing the new extension format. I gather that would mean needing to distribute two versions of MCprep right, one in extension format and one as a legacy addon? |
We could if we want to, or we could keep using only legacy builds for production. For simplicity, we should just distribute legacy builds, but make sure extension builds keep working for debug build support or for users that want to build an extension instead. |
Signed-off-by: Mahid Sheikh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main reason for requesting change is to see if I can get the extension build to properly install the debuggy wheel. Same thing happens in 4.2 and 4.3, whether dragging and dropping to install the extension, navigating manually; and same popup appears when trying to manually enable the extension's addon after the extension is installed.
Other points are less important, figure we'd want to make sure this works cross platform, even though I personally probably won't end up using it much.
name = "MCprep" | ||
tagline = "An addon for Minecraft animation workflows" | ||
maintainer = "Patrick W. Crawford <[email protected]" | ||
type = "add-on" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to accept but yes, I guess I really have been saying addon incorrectly all these years. Well at least it's better than Godot, which itself somehow references both addons and plugins as interchangeable in different contexts
"SPDX:GPL-3.0-or-later", | ||
] | ||
|
||
[permissions] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need internet as well, since we have skin downloads for username and batch.
According to the foundation, we should even try to respect the blender preference for checking if internet access overall is turned on. They don't have a way to force require it, but something for us to contemplate having a popup instead of performing the action in case that setting is off.
+wheels = [ | ||
+ "./wheels/debugpy-1.8.2-cp311-cp311-macosx_11_0_universal2.whl", | ||
+ "./wheels/debugpy-1.8.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl", | ||
+ "./wheels/debugpy-1.8.2-cp311-cp311-win_amd64.whl", | ||
+] | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, the macOS wheel should be universal across both Intel and Silicon. I'll take a look at the action
action-scripts/debug-build.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this would be here, or better over in bpy build - but it feels very broken to allow for installing extension formatted addons into 4.1 and older. Maybe bpy build should have two different lists, one for extension supports and one for legacy addon? Or hard code that if using extension mode, only allow 4.2+ installs (could be a install version filter hook)
or, we could have some metadata where each action has a sublist in the yaml which defines something like compatibility minimums..? Just some ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are plans for BpyBuild to handle extensions properly (already implemented technically, but some things still need to be finished, such as building legacy addons and extensions at the same time). Compatibility minimums would be something interesting to add for 0.5
(Also, while not related to the v3.6.1 release, could be nice to merge by then I'd say since this seems pretty close otherwise) |
Found this works to at least enable the extension/addon in 4.3 as-is today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on the wheel change we did for osx, knowing we might go a bit further in the future (I won't be using this mode in the meantime anyways)
This adds the ability to create a build of MCprep that can then be debugged using a debugger. Under the hood, this uses Microsoft's debugpy library, which is then installed into the Blender environment using the new wheels system introduced with Extensions (support for which has also been added).
This has been tested with VScode, but in theory should be editor agnostic. Some notes to be aware of:
~/.config/blender/4.2/extensions/user_default/mcprep/
). Hopefully we can get this ironed out by either including some configs or having thedebug
action generate them on the fly.bab -b dev extension debug
Closes #604