Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-platform builds using GitHub workflows #70

Closed
wants to merge 2 commits into from

Conversation

maksimstojkovic
Copy link

@maksimstojkovic maksimstojkovic commented Sep 13, 2021

Hi,

Please provide enough information so that others can review your pull request:

This pull request implements docker buildx to create multi-platform builds of the monogramm/docker-dolibarr image.
The general structure of this branch has been replicated in https://github.com/maksimstojkovic/docker-dolibarr-arm, which has successfully pushed a multi-platform image to maksimstojkovic/dolibarr. This image has been tested on a Raspberry Pi 4 running 64-bit Ubuntu 20.04 LTS and is functional.

An effort has been made to ensure all variables are consistent with the current monogramm/docker-dolibarr GitHub and DockerHub naming schemes. QEMU and docker buildx have been added to the GitHub workflow for building and testing. An additional manual workflow was created to demonstrate how multi-platform images can be pushed to DockerHub.

All major changes were added to the first commit. The second commit contains updates to images, which were generated by running ./update.sh. The second commit also executed the equivalent of chmod +x on hook scripts within the repo.

Explain the details for making this change. What existing problem does the pull request solve?

The purpose of implementing these changes is to allow devices running armhf and arm64, such as the Raspberry Pi 3 and Raspberry Pi 4, respectively, to run the monogramm/docker-dolibarr image.

Merging proposed changes should not have any impact on the performance of existing amd64 containers. Instead, it aims to extend current functionality to allow devices using different platforms to pull from the same image tag.

closes #54

Screenshots/GIFs

N/A

I'm happy to answer any questions about changes I've made.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 2, 2022
@stale stale bot closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker ARM build
1 participant