Update Persistence with attributeModifier Member #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgacy
commented
May 10, 2024
| /// - timestampProvider: A timestamp provider. | ||
| /// - put: A closure to persist item attributes. | ||
| /// - Returns: A `Persistence` instance. | ||
| static func addingTimestamp( |
There was a problem hiding this comment.
I first considered an initializer, but this struck me as a little more explicit (though I don't love the name)
jagreenwood
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the live implementation of
PersistenceFactorywas created with a closure to support adding extra attributes (like a timestamp) to persisted values. This made it difficult to test that those values were actually added since the attribute addition was coupled with the use of DynamoDB to persist entities.This fixes that by moving that closure to
Persistenceso that it can be tested independently of the logic used to actually persist values (via theputattribute) and revisions it more generally as a closure to modify persisted values. It also adds a member to create aPersistenceinstance that adds a timestamp to all persisted entities and a test for it.