Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose Update to Manifesto - Add test env content #359

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

nbeck415
Copy link
Contributor

Description

  • This enables the Prod-Like Test Env pages and includes content about staging and ephemeral environments
  • This adds EphemeralEnvironments.io link to the homepage
  • Add self to signatories and contributors

Fixes # (issue)
#358

Type of change

Changes to supporting information

Please delete the option that is not relevant.

  • Signature (please update title to "Signature 'your name'")
  • Propose Update to Manifesto (please update title to "Propose Update to Manifesto - 'update description'")

Please close this and let me know if I should create a separate PR for my signature.

@nbeck415 nbeck415 requested a review from a team as a code owner December 14, 2023 16:35
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for minimumcd ready!

Name Link
🔨 Latest commit 3ab2a33
🔍 Latest deploy log https://app.netlify.com/sites/minimumcd/deploys/659867b9c999ca0008374f44
😎 Deploy Preview https://deploy-preview-359--minimumcd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75
Accessibility: 82
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ferrix
Copy link
Collaborator

ferrix commented Dec 17, 2023

Adding ephemeral environments to the front page is not going to be fine to all the signatories. There are other ways to have production-like test environments and ephemeral is neither possible nor required in all situations. The goal of MinimumCD is to be applicable to software engineering in general.

Example:

When hardware is concerned, the pipeline may consist of proprietary physical test fixtures that cannot be ephemeral.

@ferrix ferrix added question Further information is requested under discussion labels Dec 17, 2023
Copy link
Collaborator

@bdfinst bdfinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've been taking a break over the holidays.

I agree with @ferrix that ephemeral environments are an example of an implementation, but not true in every context. For example, firmware pipelines often contain real hardware.

I suggest having the main page link to the "Prod Like" page and have that page describe ephemeral environments as an example implementation with a link to ephemeralenvironments.io.

Copy link
Collaborator

@bdfinst bdfinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdfinst bdfinst removed question Further information is requested under discussion labels Jan 12, 2024
@bdfinst bdfinst merged commit 99dd070 into Minimum-CD:master Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants