Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility by not skipping a heading level for contributor/signature counts #356

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jmp
Copy link
Contributor

@jmp jmp commented Dec 4, 2023

Description

This fixes a minor accessibility issue with skipped headings on the main page: The heading level jumps from level 2 straight to level 4 in the contributor and signature lists. This goes against accessibility best practices, for example according to W3C:

Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example.
https://www.w3.org/WAI/tutorials/page-structure/headings/#heading-ranks

The fix is to simply use heading level 3 (instead of level 4) for the contributor/signature counts.

After this change, the contributor and signature count font becomes slightly bigger. But it doesn’t look too bad, at least in my opinion:

Before:
image
After:
image

Type of change

This only changes the presentation of the contributor/signature counts. There are no changes to the manifesto text itself.

This follows the best practice of not skipping from heading levels.
@jmp jmp requested a review from a team as a code owner December 4, 2023 18:51
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for minimumcd ready!

Name Link
🔨 Latest commit 2e0bcb1
🔍 Latest deploy log https://app.netlify.com/sites/minimumcd/deploys/656e1faba4f5bd0007221208
😎 Deploy Preview https://deploy-preview-356--minimumcd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74
Accessibility: 82
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@bdfinst bdfinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. I'm adding you as a contributor as well.

@bdfinst bdfinst merged commit 2ce9d05 into Minimum-CD:master Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants