Skip to content

Commit

Permalink
Merge branch 'master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
ferrix authored Dec 30, 2023
2 parents a5700d7 + b5a8859 commit e5341e0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion content/Journey/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Having more than one reviewer on a PR is a process smell for issues with the qua

### Tests are deferred or skipped

We must treat tests as first-class citizens. They are more important than the code we are testing. They cannot be an afterthought and we need to make sure we are using them to increase our confidence rather than meeting some arbitrary ["coverage metric"](https://dojoconsortium.org/metrics/code-coverage/). We don't need all of the legacy code to be 100% tested, or even 1% tested to start CI. We need to commit to "we will never push untested changes." Timelines are irrelevant if we deliver things on time that are broken.
We must treat tests as first-class citizens. They are more important than the code we are testing. They cannot be an afterthought and we need to make sure we are using them to increase our confidence rather than meeting some arbitrary ["coverage metric"](https://dojoconsortium.org/docs/metrics/code-coverage/). We don't need all of the legacy code to be 100% tested, or even 1% tested to start CI. We need to commit to "we will never push untested changes." Timelines are irrelevant if we deliver things on time that are broken.

### The team lacks knowledge on how to write tests for CI

Expand Down
2 changes: 1 addition & 1 deletion content/MinimumCD/CI/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ You don't need any tests in existing code to begin. You need to test new code wi

### What code coverage percentage should we set as a standard for all teams?

We shouldn't. Code coverage mandates incentivize meaningless tests that hide the fact that code is not tested. It is better to have no tests than to have tests you do not trust. See the [Dojo Consortium's info](https://dojoconsortium.org/metrics/code-coverage/) on this metric.
We shouldn't. Code coverage mandates incentivize meaningless tests that hide the fact that code is not tested. It is better to have no tests than to have tests you do not trust. See the [Dojo Consortium's info](https://dojoconsortium.org/docs/metrics/code-coverage/) on this metric.
2 changes: 1 addition & 1 deletion data/names/contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ list:
- name: Istvan Bathazi
contact: https://www.linkedin.com/in/istvan-bathazi
- name: Kaine Bent
contact: https://www.ka1ne.com
contact: https://www.linkedin.com/in/ka1ne/
- name: Marc Boudreau
contact: https://www.linkedin.com/in/marc-boudreau
- name: Kelly Brownsberger
Expand Down
2 changes: 2 additions & 0 deletions data/names/signatures.yml
Original file line number Diff line number Diff line change
Expand Up @@ -373,3 +373,5 @@ list:
contact: https://www.linkedin.com/in/jarkko-piiroinen/
- name: Marc Loupias
contact: https://www.linkedin.com/in/marc-loupias-4aa71491/
- name: Paul Hammond
contact: https://www.linkedin.com/in/paul-hammond-bb5b78251/

0 comments on commit e5341e0

Please sign in to comment.