Memoize transaction related hashes #16056
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hashes that are computed during staged ledger application are dependent only on a transaction itself. These hashes could be precomputed before staged ledger application, to minimize time of block creation.
Main change revolves around introducing and using the following two types:
Type
precomputed_t
contains data that is dependent only on a transaction (and not on the ledger to which it is to be applied). It contains some hashes either in direct form (asmemo_hash
) or indirect form (asall_account_updates
, for computation of which some hashing is used deep inside the function call).TODO this PR lacks a change to block producer to keep
precomputed_t
in transaction pool and use for block creation.As measured by
mina ledger test apply
benchmark, this PR improves performance of staged ledger diff application by some 27% (measured together with #15784, #15980, #16055).Explain how you tested your changes:
Checklist: