Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle images might not be accurate #5

Open
MikeBishop opened this issue Jun 10, 2020 · 1 comment
Open

Vehicle images might not be accurate #5

MikeBishop opened this issue Jun 10, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MikeBishop
Copy link
Owner

Right now, the car shown is always, well, mine. 😁

It should be possible to build the compositor URLs from the VehicleData and display the car indicated, but that's going to take some work. Some kind souls have already contributed some pointers in the right direction, but this is a big chunk of work for a relatively minor result.

@MikeBishop MikeBishop added enhancement New feature or request help wanted Extra attention is needed labels Jun 10, 2020
@MikeBishop
Copy link
Owner Author

MikeBishop commented Jun 13, 2020

4ee9797 uses the API to generate compositor URLs that reflect the settings in the API, at least so far as vehicle model, exterior color, and wheels are concerned. However, it's entirely possible this conversion is incomplete. I think it should produce a reasonable image in most/all cases.

If you notice that your vehicle image is broken, please provide the following:

  • The correct URL for your vehicle image, e.g. from your account page on Tesla.com
  • The values returned from the Tesla API (https://owner-api.teslamotors.com/api/1/vehicles/<vehicle id>/data_request/vehicle_config)

@MikeBishop MikeBishop changed the title Use compositor images Vehicle images might not be accurate Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant