-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image of the car? #193
Comments
I don't know what the official Tesla app is doing, but for Nikola I decided that I have had to maintain a mapping from known vehicle_config varieties to option codes. Would love to know if there's a better way to do it, but have yet to find it. |
@davidhodge How are you able to detect Model 3 Performance in Nikola from the vehicle_config? I'm not seeing anything obviously different than a standard Model 3. |
Why is this closed? I think this still a valid question... |
Yeah I also don't necessarily think this should be closed. There is a valid approach to getting vehicle option codes. We should work to figure this out. |
This isn't part of the API. The options codes haven't worked properly for years. However one gets a picture of their car using this image generation service isn't going to be done through this API, hence I closed this out. |
Hmm I don't think we can completely rule out that the API won't give us access to option codes or a vehicle image. Just some from endpoints:
There's something to be said for if a token intended for owner-api use will allow access to these, however I think this is def worth figuring out. Best case, it does. |
The API gives you option codes, but those have been the same option codes (regardless of the actual car configuration) for any vehicles produced in the last few years. They're not the same ones provided by the Tesla Account site where this image lives. |
Right, I'm thinking there's a possibility for a new source for correct option codes in the API. |
I also think, there is a valid way to get the option codes... Somewhere... |
They get that from the Options codes mostly came from Salesforce data. The website might be obtaining it directly as an option code list and the mobile app API might be translating that data to the semantic structure for the |
Something like this? |
Yes, that is one major piece of code I drew from to generate my own translation. |
Perhaps you can share the code? |
@timdorr Perhaps we should add these mappings somewhere to the Documentation. And enhance it, when there will be new mappings? |
We have the option codes listed here: https://github.com/timdorr/tesla-api/blob/master/docs/vehicle/optioncodes.md But how they're translated to the API data seems like a futile effort because they change so often and we don't know if Tesla will introduce further structural changes. That seems like a lot of work to map to just this one single image generation service 🤷 |
I think it would be grate, to have a source of information for this...
|
Added, thank you! I'll take any other updates here. |
The app is clearly able to generate an image of the car. From some inspection on the Tesla web site, it looks like it's using a URL like....
However, since the options codes in the API have been frozen/deprecated, clearly they're getting the list of options from someplace else. It's possible they're just translating things off data_request/vehicle_config, in which case the translation database must be a pain to manage. Any chance to retrieve that translation code? Can you tell if the app using the same approach to get the vehicle image?
The text was updated successfully, but these errors were encountered: