Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated command set #3569

Closed
wants to merge 6 commits into from
Closed

Conversation

Xelu86
Copy link
Contributor

@Xelu86 Xelu86 commented Jul 26, 2023

PR Summary

  • Updated Hyper-V Module with current information
  • Cmdlet name - Changed bolded text to code spans
  • Parameters - Changed italic text to bold
  • Parameters - Changed code span text to bold
  • Applied text contractions
  • Applied syntax reflows
  • Fixed indented code blocks

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the [contributors guide][contrib].
  • Style: This PR adheres to the [style guide][style].

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e5717df:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit e5717dff6490584e2fc22edffe1b176c5bd9a1fd in branch New_HyperV_VHD_Update of repository https://github.com/Xelu86/windows-powershell-docs into branch main (commit f52a90a8e5ed75cab23300617ed77ba336ae5287). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d9e0c69:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/hyper-v/Convert-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Dismount-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Get-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Merge-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Mount-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/New-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Optimize-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Resize-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Set-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Test-VHD.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@scanum scanum assigned ghost , get-itips and scanum Jul 27, 2023
@@ -11,45 +11,52 @@ title: Test-VHD
# Test-VHD

## SYNOPSIS
Tests a virtual hard disk for any problems that would make it unusable.
Tests a virtual hard disk for any problems that'd make it unusable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tests a virtual hard disk for any problems that'd make it unusable.
Tests a virtual hard disk for any problems that would make it unusable.

```
Test-VHD [-Path] <String[]> [-SupportPersistentReservations] [-CimSession <CimSession[]>]
[-ComputerName <String[]>] [-Credential <PSCredential[]>] [<CommonParameters>]
```

## DESCRIPTION
The **Test-VHD** cmdlet tests a virtual hard disk for any problems that would make it unusable.

The `Test-VHD` cmdlet tests a virtual hard disk for any problems that'd make it unusable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `Test-VHD` cmdlet tests a virtual hard disk for any problems that'd make it unusable.
The `Test-VHD` cmdlet tests a virtual hard disk for any problems that would make it unusable.

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review - @Xelu86, kindly commit the suggested changes. Many thanks.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit f6c981a:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/hyper-v/Convert-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Dismount-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Get-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Merge-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Mount-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/New-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Optimize-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Resize-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Set-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Test-VHD.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@get-itips
Copy link
Contributor

Are any of these changes also applicable to other OS versions of the articles? if so, can you also update them? Thank you

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 73d7bcf:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/hyper-v/Convert-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Dismount-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Get-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Merge-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Mount-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/New-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Optimize-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Resize-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Set-VHD.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/hyper-v/Test-VHD.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

PS C:\> Convert-VHD -Path c:\test\testvhd.vhd -DestinationPath c:\test\testvhdx.vhdx

```powershell
Convert-VHD -Path C:\test\testvhd.vhd -DestinationPath C:\test\testvhdx.vhdx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the PowerShell prompt back as this is an illustrative example. Review your other examples as well as many, if not all, appear to be illustrative and should have this change reverted.

@@ -246,16 +274,22 @@ Aliases: wi

Required: False
Position: Named
Default value: False
Default value: None
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-WhatIf is a SwitchParameter which is either $true or $false. Please review your other -WhatIf changes.

@scanum
Copy link

scanum commented Aug 6, 2023

@Xelu86 hope all is well. Could you please submit the changes?

@scanum
Copy link

scanum commented Oct 2, 2023

We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.

Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@scanum scanum closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants