Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share basket by URL #46

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

DylanHojnoski
Copy link
Contributor

There is a new export option that to share a that contains the basket data. It pulls the ids of the courses, sections, and search queries along with the name of the basket and semester and puts the data into the URL. The router on the homepage then parses the URL and creates a new basket based off of the data in the URL. It also changes the selected semester to the one of the new basket and sets it as the current basket.

Copy link

vercel bot commented Mar 5, 2024

@DylanHojnoski is attempting to deploy a commit to a Personal Account owned by @Michigan-Tech-Courses on Vercel.

@Michigan-Tech-Courses first needs to authorize it.

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mtucourses-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:34am

Copy link
Member

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great! one thing that might be nice from a UX perspective is to automatically copy the link to the clipboard when the disclosure opens (and tell the user it was copied with a toast or a message in the disclosure)

@codetheweb
Copy link
Member

I updated the workflow settings, they should run automatically in the future.

@DylanHojnoski
Copy link
Contributor Author

Created modal where you confirm if you want to import the basket.

image

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 35.59322% with 38 lines in your changes missing coverage. Please review.

Project coverage is 31.88%. Comparing base (b9b81de) to head (fe92c95).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/components/basket/import/import.tsx 33.33% 22 Missing ⚠️
src/pages/index.tsx 45.00% 8 Missing and 3 partials ⚠️
src/components/basket/table.tsx 25.00% 3 Missing ⚠️
src/components/basket/export-options/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   31.84%   31.88%   +0.03%     
==========================================
  Files         105      106       +1     
  Lines        2490     2550      +60     
  Branches      410      417       +7     
==========================================
+ Hits          793      813      +20     
- Misses       1640     1676      +36     
- Partials       57       61       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants