-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share basket by URL #46
base: master
Are you sure you want to change the base?
Share basket by URL #46
Conversation
@DylanHojnoski is attempting to deploy a commit to a Personal Account owned by @Michigan-Tech-Courses on Vercel. @Michigan-Tech-Courses first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great! one thing that might be nice from a UX perspective is to automatically copy the link to the clipboard when the disclosure opens (and tell the user it was copied with a toast or a message in the disclosure)
I updated the workflow settings, they should run automatically in the future. |
…en changing semesters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 31.84% 31.88% +0.03%
==========================================
Files 105 106 +1
Lines 2490 2550 +60
Branches 410 417 +7
==========================================
+ Hits 793 813 +20
- Misses 1640 1676 +36
- Partials 57 61 +4 ☔ View full report in Codecov by Sentry. |
There is a new export option that to share a that contains the basket data. It pulls the ids of the courses, sections, and search queries along with the name of the basket and semester and puts the data into the URL. The router on the homepage then parses the URL and creates a new basket based off of the data in the URL. It also changes the selected semester to the one of the new basket and sets it as the current basket.