Kotlin Gradle #4831
Open
Kotlin Gradle #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few things left to run by crosby or mimgam tomorrow :3
Somehow failing to fetch stuff from modrinth maven?
‼️ ‼️ ‼️ ‼️ ‼️
Apparently it needs both outside a dev environment! Look at me testing all the stuff :D
|
based pr tbh |
Small upsides, maybe, but not pointless? The build times are faster, and Kotlin gives more robust errors and is often easier to comprehend for new devs who already started on Java because its syntax is much stricter. If you have any legit concerns though I'm glad to listen ^^ |
anything that removes groovy dsl will never be pointless |
RacoonDog
suggested changes
Aug 23, 2024
|
|
||
| jar { | ||
| from("LICENSE") { | ||
| rename{ |
There was a problem hiding this comment.
add a space (rename {) and make into single line, like in the shadowJar task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Changes the main project and subproject to use the Kotlin Gradle DSL, slightly faster build times and an overall easier to read file
Related issues
N/A
How Has This Been Tested?
Worked in both the runClient fabric task as well as the default Minecraft Client configuration by the mcdev plugin, built jar works when tested on a new Prism 1.21.1 instance
Checklist: