Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Removes
PacketUtilsUtils
in favor of filling thePacketUtils
maps using the newPlayStateFactories
vanilla registry.Instead of being identified by their yarn class names, the new packet names follow the following convention:
namespace:Side/UpperCamelCaseName
. The namespaceminecraft
is implicit, mapping vanilla packets will return a name fittingSide/UpperCamelCaseName
, however you can still unmap vanilla packets with and without the namespace.To match vanilla use cases,
PacketUtils
andPacketListSetting
methods that used to takeClass<? extends Packet<?>>
parameters now takePacketType<? extends Packet<?>>
instead.Since we are effectively moving away from packets named with yarn mappings to official identifiers, this means that existing
PacketListSetting
saved configs will be reset, and some packets may appear under completely different names.How Has This Been Tested?
Works greate
Checklist: