Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.5/.6 update #4534

Merged
merged 33 commits into from
May 3, 2024
Merged

Conversation

Big-Iron-Cheems
Copy link
Collaborator

@Big-Iron-Cheems Big-Iron-Cheems commented Apr 20, 2024

Type of change

  • Bug fix
  • New feature

Description

Update Meteor for 1.20.5/.6
The 1.20.5 compatibility will be dropped if necessary later on.

Related issues

None.

How Has This Been Tested?

This is still WIP, it builds and runs, but could have some bugs.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

Big-Iron-Cheems and others added 8 commits April 20, 2024 20:21
Throwing everything at the wall to see what sticks :3

- does not build
- several classes must be fixed (especially the ones master Crosby wrote)
- I am nt sure of my own work, please triple check everything
- this is a plea for help, the fog is coming
Now passes the `toggle all on|off` test
- TODO: fix all the GUIs not appearing
- Use new SequencedCollection getters
- Apply `abstract` to all mixins
- Add private constructor to all Util classes
@ModxVoldHunter
Copy link

gonna build the jar and test to see if there is any bugs before any changes are made

@Wide-Cat
Copy link
Collaborator

sure more eyes looking for bugs is always welcome

@ModxVoldHunter
Copy link

sure more eyes looking for bugs is always welcome

i don't see anything wrong, looks good to me.

@ModxVoldHunter
Copy link

nvm when using meteor and placing anything that isn't cobblestone makes the placing stone sound

@ModxVoldHunter
Copy link

nvm when using meteor and placing anything that isn't cobblestone makes the placing stone sound

and i found out it was "No Ghost Blocks" causing the issue

@DataGoblin
Copy link

DataGoblin commented Apr 24, 2024

There is a rendering issue with waypoints. They are either stickied randomly in a corner on the HUD or not visible.

Tested build with commit 6509957

Big-Iron-Cheems and others added 2 commits April 24, 2024 17:41
- added missing ``@Unique` to mixins
- updated gradle-wrapper.jar and scripts
- fix duplicate entry in Xray
@RedCarlos26
Copy link
Contributor

@DataGoblin was this fixed?

@Wide-Cat
Copy link
Collaborator

@DataGoblin was this fixed?

Minegame is looking at it

@ModxVoldHunter
Copy link

Was the bug I mentioned, fixed or being looked at?

@Wide-Cat
Copy link
Collaborator

Yes

@phpmypython
Copy link

What are the chances of this getting merged soon?

@Big-Iron-Cheems
Copy link
Collaborator Author

What are the chances of this getting merged soon?

We don't have an ETA, It'll be out once we say it's ready.
There's still some things we want to look at.

@phpmypython
Copy link

What are the chances of this getting merged soon?

We don't have an ETA, It'll be out once we say it's ready. There's still some things we want to look at.

I'm happy to help test some stuff if you let me know what things still need testing.

- Suppressed some warnings
- updated build.gradle (now includes our license in the built JAR)
@Wide-Cat
Copy link
Collaborator

PSA we are going to wait until 1.20.6 gets released before we merge this and update, since the versions are near identical. Unless more issues are found, Mojang will probably release it around Tuesday next week, so the expected timescale is this will likely be merged either on Tuesday or Wednesday (depending on when Mojang releases).

@ModxVoldHunter
Copy link

PSA we are going to wait until 1.20.6 gets released before we merge this and update, since the versions are near identical. Unless more issues are found, Mojang will probably release it around Tuesday next week, so the expected timescale is this will likely be merged either on Tuesday or Wednesday (depending on when Mojang releases).

would you like someone to make a preview version of meteor on a minecraft test snapshot to see if it will work?

Wide-Cat and others added 10 commits April 28, 2024 19:40
- stricter checks for map validity
- added end city locator
- `ChatUtils#formatCoords` no longer makes the coords bold, hoverable and clickable if baritone is not available
- no clue if `minecraft:register` or `fabric` should be kept
NOTE: Crosby said he'd work on rewriting them as a standalone library
- might mark as 1.20.5 compatible if deemed necessary
- removed some unused classes from the good old times
- also bump the minimum compatible release of Sodium
- remove once a breaking change, if any, arises
@Big-Iron-Cheems Big-Iron-Cheems changed the title 1.20.5 update 1.20.5/.6 update Apr 30, 2024
@desplmfao
Copy link

desplmfao commented Apr 30, 2024

there is an crash whenever the server kicks the player

[12:21:04] [Render thread/ERROR]: Unreported exception thrown!
java.lang.NullPointerException: Cannot invoke "meteordevelopment.meteorclient.mixin.ClientPlayerEntityAccessor.setTicksSinceLastPositionPacketSent(int)" because "this.mc.field_1724" is null
	at meteordevelopment.meteorclient.systems.modules.movement.Flight.onPostTick(Flight.java:145) ~[meteor-client-0.5.6.jar:?]
	at meteordevelopment.orbit.listeners.LambdaListener.call(LambdaListener.java:83) ~[meteor-client-0.5.6.jar:?]
	at meteordevelopment.orbit.EventBus.post(EventBus.java:53) ~[meteor-client-0.5.6.jar:?]
	at net.minecraft.class_310.handler$bbc002$meteor-client$onTick(class_310.java:6809) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1574(class_310.java:2063) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1281) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:888) [client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) [fabric-loader-0.15.10.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.15.10.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.15.10.jar:?]
[12:21:04] [Thread-6/INFO]: Saving```

with stack deobfuscator

```[12:22:57] [Render thread/ERROR]: Unreported exception thrown!
java.lang.NullPointerException: Cannot invoke "net.minecraft.client.network.ClientPlayerEntity.getYaw()" because "this.mc.player" is null
	at meteordevelopment.meteorclient.systems.modules.movement.Flight.onPostTick(Flight.java:153) ~[meteor-client-0.5.6.jar:?]
	at meteordevelopment.orbit.listeners.LambdaListener.call(LambdaListener.java:83) ~[meteor-client-0.5.6.jar:?]
	at meteordevelopment.orbit.EventBus.post(EventBus.java:53) ~[meteor-client-0.5.6.jar:?]
	at MC/net.minecraft.client.MinecraftClient.handler$bbc002$meteor-client$onTick(MinecraftClient.java:6809) ~[client-intermediary.jar:?]
	at MC/net.minecraft.client.MinecraftClient.tick(MinecraftClient.java:2063) ~[client-intermediary.jar:?]
	at MC/net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1281) ~[client-intermediary.jar:?]
	at MC/net.minecraft.client.MinecraftClient.run(MinecraftClient.java:888) [client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) [fabric-loader-0.15.10.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.15.10.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.15.10.jar:?]
[12:22:57] [Thread-6/INFO]: Saving```

@MineGame159 MineGame159 marked this pull request as ready for review May 3, 2024 19:08
@MineGame159 MineGame159 merged commit f5e042f into MeteorDevelopment:master May 3, 2024
1 check passed
@Big-Iron-Cheems Big-Iron-Cheems deleted the 1.20.5-update branch May 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants