Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old token details page #27774

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Oct 10, 2024

Description

There used to be an inner token details page nested within the asset page, that you accessed from the kebab menu:

Screenshot 2024-10-10 at 11 14 05 AM

But with the redesign of the asset page in #24522, there is no longer any way to access this page. The equivalent data and hide functionality is now directly on the main asset page.

This PR removes the component.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Comment on lines -372 to -376
<Authenticated
path={`${TOKEN_DETAILS}/:address/`}
component={TokenDetailsPage}
exact
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered trying to maintain this route and point it to the main asset page. But I think its unlikely anyone is keeping bookmarks to it.

@bergeron bergeron marked this pull request as ready for review October 10, 2024 18:40
@bergeron bergeron requested a review from a team as a code owner October 10, 2024 18:40
Copy link

sonarcloud bot commented Oct 10, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [b535c2f]
Page Load Metrics (1755 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148423031763233112
domContentLoaded14752294172720197
load148423191755209100
domInteractive25173513416
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -7.66 KiB (-0.10%)
  • common: -165 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants