-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove old token details page #27774
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
<Authenticated | ||
path={`${TOKEN_DETAILS}/:address/`} | ||
component={TokenDetailsPage} | ||
exact | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered trying to maintain this route and point it to the main asset page. But I think its unlikely anyone is keeping bookmarks to it.
Quality Gate passedIssues Measures |
Builds ready [b535c2f]
Page Load Metrics (1755 ± 100 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
There used to be an inner token details page nested within the asset page, that you accessed from the kebab menu:
But with the redesign of the asset page in #24522, there is no longer any way to access this page. The equivalent data and hide functionality is now directly on the main asset page.
This PR removes the component.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist