Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate TextField to Component Library version #27768

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Oct 10, 2024

Description

Replaced all the deprecated ui/components/ui/text-field with ui/components/component-library

This removes the following Warning:

Warning: Failed prop type: Invalid prop `disableUnderline` of type `string` supplied to `ForwardRef(Input)`, expected `boolean`.
    in ForwardRef(Input) (created by WithStyles(ForwardRef(Input)))
    in WithStyles(ForwardRef(Input)) (created by ForwardRef(TextField))
    in div (created by ForwardRef(FormControl))
    in ForwardRef(FormControl) (created by WithStyles(ForwardRef(FormControl)))
    in WithStyles(ForwardRef(FormControl)) (created by ForwardRef(TextField))
    in ForwardRef(TextField) (created by WithStyles(ForwardRef(TextField)))
    in WithStyles(ForwardRef(TextField)) (at text-field.component.js:264)
    in TextField (created by WithStyles(TextField))

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-contributor-experience MetaMask Contributor Experience Group label Oct 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [963b8f7]
Page Load Metrics (1717 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30023481651352169
domContentLoaded15222163168913364
load15292240171714871
domInteractive248042188
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -5.46 KiB (-0.07%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f2c7f3d]
Page Load Metrics (1920 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint147823721916229110
domContentLoaded146923201883232112
load147923761920236113
domInteractive14323776933
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -5.46 KiB (-0.07%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham force-pushed the migrate-textfield branch 3 times, most recently from 1bef6ce to 59d11ce Compare October 10, 2024 19:54
@metamaskbot
Copy link
Collaborator

Builds ready [59d11ce]
Page Load Metrics (2230 ± 308 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint46737472098708340
domContentLoaded160836592194648311
load161936792230642308
domInteractive17172744622
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -5.32 KiB (-0.07%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-contributor-experience MetaMask Contributor Experience Group team-extension-platform type-tech-debt Technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants