Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with Snap title in Snap Authorship Header #27752

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Oct 10, 2024

Fix issue with Snap name in Snap Authorship Header.

Description

Open in GitHub Codespaces

Related issues

Fixes: n/a

Manual testing steps

  1. Try to install a Snap with long name (e.g. Ethereum Provider Example Snap)
  2. Make sure that the title is properly truncated and all elements visible

Screenshots/Recordings

Before

Screenshot 2024-10-10 at 11 38 11
Screenshot 2024-10-10 at 11 38 28

After

Screenshot 2024-10-10 at 12 08 44
Screenshot 2024-10-10 at 12 08 57

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added the team-snaps-platform Snaps Platform team label Oct 10, 2024
@david0xd david0xd self-assigned this Oct 10, 2024
@david0xd david0xd requested a review from a team as a code owner October 10, 2024 10:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd changed the title Fix: issue with Snap title in Snap Authorship Header fix: issue with Snap title in Snap Authorship Header Oct 10, 2024
@FrederikBolding
Copy link
Member

@david0xd You'll need to update some snapshots before this will pass CI

@david0xd david0xd requested review from a team as code owners October 10, 2024 10:34
@metamaskbot
Copy link
Collaborator

Builds ready [4090886]
Page Load Metrics (1957 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47024831714531255
domContentLoaded159625811936259124
load160026111957263126
domInteractive2597452110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 34 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@david0xd david0xd added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@david0xd david0xd added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [6c88e12]
Page Load Metrics (2083 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26128711842691332
domContentLoaded184027772058252121
load185228092083261125
domInteractive257344157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 34 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@david0xd david0xd added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit b08b374 Oct 10, 2024
78 checks passed
@david0xd david0xd deleted the dd/fix-snap-header-title branch October 10, 2024 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants