-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Completing missing step for import ERC1155 token origin dapp in existing E2E test #27680
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
6f590cc
to
8775947
Compare
Hi @NiranjanaBinoy, thanks for adding the e2e test coverage. Since the mint part has already been tested, I think you can add the check block explorer and watch asset part in the same test as this one. This way, we don't need to repeat steps and will gain execution speed. |
8775947
to
935aa2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should start to implement Page Object Model for e2e test, but can be done in a separate PR.
await driver.findClickableElement( | ||
'[data-testid="account-overview__nfts-tab"]', | ||
); | ||
await driver.clickElement('[data-testid="account-overview__nfts-tab"]'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is flaking here.
Quality Gate passedIssues Measures |
Description
Adding missing Watch ERC1155 Asset step and fully cover the manual scenario here in the E2E test
test/e2e/tests/tokens/nft/erc1155-interaction.spec.js
Related issues
Fixes: #27371
Manual testing steps
yarn test:e2e:single --browser=chrome test/e2e/tests/tokens/nft/erc1155-interaction.spec.js
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist