Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Completing missing step for import ERC1155 token origin dapp in existing E2E test #27680

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Oct 7, 2024

Description

Adding missing Watch ERC1155 Asset step and fully cover the manual scenario here in the E2E test test/e2e/tests/tokens/nft/erc1155-interaction.spec.js

Open in GitHub Codespaces

Related issues

Fixes: #27371

Manual testing steps

  1. Run yarn test:e2e:single --browser=chrome test/e2e/tests/tokens/nft/erc1155-interaction.spec.js
  2. test should finish without failure
  3. The last test run should watch asset erc1155.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy force-pushed the updating-e2e-erc1155-interaction branch 3 times, most recently from 6f590cc to 8775947 Compare October 8, 2024 03:04
@chloeYue
Copy link
Contributor

chloeYue commented Oct 8, 2024

Hi @NiranjanaBinoy, thanks for adding the e2e test coverage. Since the mint part has already been tested, I think you can add the check block explorer and watch asset part in the same test as this one. This way, we don't need to repeat steps and will gain execution speed.

chloeYue
chloeYue previously approved these changes Oct 10, 2024
Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should start to implement Page Object Model for e2e test, but can be done in a separate PR.

await driver.findClickableElement(
'[data-testid="account-overview__nfts-tab"]',
);
await driver.clickElement('[data-testid="account-overview__nfts-tab"]');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is flaking here.

Copy link

sonarcloud bot commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

test: Complete missing step for import ERC1155 token origin dapp in existing E2E test
2 participants