Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry pick add amount row contract deployment #27626

Closed
wants to merge 2 commits into from
Closed

fix: cherry pick add amount row contract deployment #27626

wants to merge 2 commits into from

Commits on Oct 4, 2024

  1. fix: incomplete transactions on startup (#26963) 

    Upgrade the `TransactionController` to `37.0.0`.
Prevent various scenarios triggering the `signed or submitted` alert .
Remove unapproved transaction fixtures as no longer supported.
    @matthewwalsh0 @vinistevam
    matthewwalsh0 authored and vinistevam committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8f91561 View commit details
    Browse the repository at this point in the history

  2. fix: add amount row for contract deployment (#27594) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

This PR adds an "Amount" row to display the token value for contract
deployments when either:
- The transaction parameters include a value greater than 0, or
- The simulation fails.

This change ensures that users can see the token amount being sent
during contract deployments, even when the "Estimate balance changes"
feature is disabled.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27594?quickstart=1)

Fixes: #27525

1. Go to Remix
2. Trigger a contract deployment with some ETH
3. See no balance appears in the amount
4. Disable Transaction redesign
5. Trigger a contract deployment with some ETH
6. See balance appears in the amount

Example Contract

```
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

contract Params {
    constructor() payable {}
     receive() external payable {
    }
}
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

[amount-contract.webm](https://github.com/user-attachments/assets/131f36f6-73f6-465e-b731-bb10554d5f76)

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @vinistevam
    vinistevam committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fc3c163 View commit details
    Browse the repository at this point in the history