feat: Token send heading component #27562

pedronfigueiredo · 2024-10-02T12:21:38Z

Description

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3219

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Token with image

Token without image but with symbol

Token without image and symbol

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-02T12:21:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

OGPoyraz · 2024-10-07T11:08:13Z

ui/pages/confirmations/components/confirm/info/token-transfer/token-transfer.tsx

 const TokenTransferInfo = () => {
-  return null;
+  return <SendHeading />;


Are we going to extend this component later or will it stay just importing this?

Yes, this work continues in the next PR #27654

ui/pages/confirmations/components/confirm/info/hooks/use-selected-token.ts

ui/pages/confirmations/components/confirm/info/shared/send-heading/send-heading.tsx

ui/pages/confirmations/components/confirm/info/hooks/use-token-values.ts

metamaskbot · 2024-10-09T12:56:17Z

Builds ready [ef4b230]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1777 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1532	2221	1785	179	86
		domContentLoaded	1524	2092	1746	151	72
		load	1565	2201	1777	167	80
		domInteractive	26	152	49	30	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 6.65 KiB (0.09%)
common: 444 Bytes (0.01%)

metamaskbot · 2024-10-10T10:37:34Z

Builds ready [f873e25]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1764 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1553	2561	1765	217	104
		domContentLoaded	1538	2316	1723	174	83
		load	1547	2445	1764	200	96
		domInteractive	24	152	50	30	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 6.68 KiB (0.09%)
common: 439 Bytes (0.01%)

sonarcloud · 2024-10-10T10:54:58Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

metamaskbot · 2024-10-10T11:14:15Z

Builds ready [2203d10]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1866 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	737	2457	1813	321	154
		domContentLoaded	1584	2443	1840	203	97
		load	1592	2455	1866	198	95
		domInteractive	16	196	54	49	24

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 6.65 KiB (0.09%)
common: 439 Bytes (0.01%)

pedronfigueiredo requested review from a team as code owners October 2, 2024 12:21

github-actions bot added the team-confirmations Push issues to confirmations team label Oct 2, 2024

pedronfigueiredo self-assigned this Oct 2, 2024

pedronfigueiredo force-pushed the pnf/3219 branch 3 times, most recently from 3b26140 to 0fad022 Compare October 4, 2024 13:27

OGPoyraz previously approved these changes Oct 7, 2024

View reviewed changes

pedronfigueiredo dismissed OGPoyraz’s stale review via ab43b86 October 7, 2024 14:51

pedronfigueiredo force-pushed the pnf/3219 branch from c93e4c4 to ab43b86 Compare October 7, 2024 14:51

matthewwalsh0 requested changes Oct 7, 2024

View reviewed changes

pedronfigueiredo force-pushed the pnf/3219 branch 2 times, most recently from f581e9c to ef4b230 Compare October 9, 2024 12:25

pedronfigueiredo force-pushed the pnf/3219 branch 2 times, most recently from 82b2ec7 to f873e25 Compare October 10, 2024 10:04

pedronfigueiredo force-pushed the pnf/3219 branch from f873e25 to 34f2b40 Compare October 10, 2024 10:42

pedronfigueiredo added 8 commits October 10, 2024 11:42

feat: Custom header for wallet initiated confirmations

11ce68a

feat: Token send heading component

d1e35ed

Remove incomplete test file

8863f26

wip

01136d8

fix import

b0b22e4

fix storybook import

001727c

wip

2b89130

fix unit test

2203d10

pedronfigueiredo force-pushed the pnf/3219 branch from 34f2b40 to 2203d10 Compare October 10, 2024 10:42

OGPoyraz approved these changes Oct 10, 2024

View reviewed changes

jpuri approved these changes Oct 10, 2024

View reviewed changes

matthewwalsh0 approved these changes Oct 10, 2024

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Oct 10, 2024

Merged via the queue into develop with commit 1bd1fa4 Oct 10, 2024
77 of 78 checks passed

pedronfigueiredo deleted the pnf/3219 branch October 10, 2024 16:45

github-actions bot locked and limited conversation to collaborators Oct 10, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Token send heading component #27562

feat: Token send heading component #27562

pedronfigueiredo commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024

OGPoyraz Oct 7, 2024

pedronfigueiredo Oct 10, 2024

metamaskbot commented Oct 9, 2024

metamaskbot commented Oct 10, 2024

sonarcloud bot commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

feat: Token send heading component #27562

feat: Token send heading component #27562

Conversation

pedronfigueiredo commented Oct 2, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Token with image

Token without image but with symbol

Token without image and symbol

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 2, 2024

OGPoyraz Oct 7, 2024

Choose a reason for hiding this comment

pedronfigueiredo Oct 10, 2024

Choose a reason for hiding this comment

metamaskbot commented Oct 9, 2024

metamaskbot commented Oct 10, 2024

sonarcloud bot commented Oct 10, 2024

Quality Gate failed

metamaskbot commented Oct 10, 2024

pedronfigueiredo commented Oct 2, 2024 •

edited

Loading