fix: Hide redesigned contract interaction confirmation

[pedronfigueiredo]

Description

Hides redesigned contract interaction confirmation for this release.

Even if the user opts into the redesigned confirmations through the experimental settings, s/he will not see any redesigned transaction confirmations.

Some tests in useConfirmationAlertMetrics and one from useConfirmationAlertMetrics were removed because the metrics event is only sent for enabled redesign transaction types which is now empty

  const isValidType = REDESIGN_TRANSACTION_TYPES.includes(
    currentConfirmation?.type as TransactionType,
  );

Tests for transactions in useCurrentConfirmation similarly expected contract interaction as a transaction type since it was the first implemented.

Tests for useSigningOrSubmittingAlerts and usePendingTransactionAlertssimilarly usedisValidType` shown above to determine wether or not to show the alert, so a few test cases had to be amended.

One snapshot for the header component had to be updated because the advanced details toggle button is only shown for redesigned transaction types.

One integration test for the contract interaction type was skipped.

Eight e2e tests for this transaction type, one for metrics and one related to snaps functionality for this transaction type were skipped.

Related issues

Fixes:

Manual testing steps

1. Enable redesigned transaction screens in the experimental settings page
2. Create a contract interaction transaction via the mint erc721 button in the test dapp
3. The old confirmation screen should appear.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (439f7d6) to head (cdc96be).
Report is 20 commits behind head on Version-v12.3.0.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27346      +/-   ##
===================================================
- Coverage            70.24%   70.07%   -0.17%     
===================================================
  Files                 1426     1432       +6     
  Lines                50239    50428     +189     
  Branches             13954    13990      +36     
===================================================
+ Hits                 35289    35335      +46     
- Misses               14950    15093     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [cdc96be]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1854 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	236	2180	1773	373	179
		domContentLoaded	1655	2125	1808	119	57
		load	1707	2194	1854	124	60
		domInteractive	12	105	43	20	10

[pedronfigueiredo]

This was a back up plan for the release, not needed anymore